[PR #3781] [MERGED] Feat: rename stack inline #5876

New issue

Closed

opened 2026-03-23 22:20:42 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3781
Author: @Xazin
Created: 10/25/2023
Status: ✅ Merged
Merged: 10/26/2023
Merged by: @richardshiue

Base: main ← Head: feat/rename-stack-inline

📝 Commits (10+)

99c3bc2 feat: rename stack in-line
63f8ee2 feat: rename stack in-line
df92f3c chore: compiler issues
49ef2b1 Merge branch 'feat/rename-stack-inline' into temp
60188b4 fix: implement fieldId for update group
d575861 fix: conflicts and cleaning
6136c96 Merge branch 'main' into feat/rename-stack-inline
99d2ffc fix: code lost after merge
6991259 test: fix failing rust tests
ec3e619 fix: tauri localization wrong keys

📊 Changes

24 files changed (+516 additions, -221 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/application/group/group_service.dart (+7 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart (+50 -36)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+66 -156)
➕ frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/widgets/board_column_header.dart (+228 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_extension.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/text_cell/text_cell_bloc.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/date_time/date_format_ext.dart (+1 -1)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/app-dialog/ConfirmDialog.tsx (+1 -1)
📝 frontend/appflowy_tauri/src/appflowy_app/components/board/BoardGroup.tsx (+1 -1)
📝 frontend/appflowy_tauri/src/appflowy_app/components/layout/NestedPage/RenameDialog.tsx (+2 -2)
📝 frontend/resources/translations/en.json (+2 -1)
📝 frontend/rust-lib/event-integration/src/database_event.rs (+2 -0)
📝 frontend/rust-lib/event-integration/tests/database/local_test/test.rs (+10 -3)
📝 frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs (+11 -2)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+11 -4)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+26 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+23 -1)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller.rs (+5 -0)

...and 4 more files

📄 Description

Enables renaming a Column/Stack inline, however in its current version only for Single- and Multi-select groups.

Relates: #3703

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3781 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/25/2023 **Status:** ✅ Merged **Merged:** 10/26/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/rename-stack-inline` --- ### 📝 Commits (10+) - [`99c3bc2`](https://github.com/AppFlowy-IO/AppFlowy/commit/99c3bc216107bc1a90aa3db46a4dadc01d987d80) feat: rename stack in-line - [`63f8ee2`](https://github.com/AppFlowy-IO/AppFlowy/commit/63f8ee267c93454546adfa2ce4635788d1dde288) feat: rename stack in-line - [`df92f3c`](https://github.com/AppFlowy-IO/AppFlowy/commit/df92f3c2bc7358ea609af3f10d38b407d0aa569a) chore: compiler issues - [`49ef2b1`](https://github.com/AppFlowy-IO/AppFlowy/commit/49ef2b1cc7708f7d9a7c147924da7164fd7429fa) Merge branch 'feat/rename-stack-inline' into temp - [`60188b4`](https://github.com/AppFlowy-IO/AppFlowy/commit/60188b4a5850277f6d7ed6f288d200a1b0556a76) fix: implement fieldId for update group - [`d575861`](https://github.com/AppFlowy-IO/AppFlowy/commit/d575861fa9450fc54d2c8e91be338832cc15d266) fix: conflicts and cleaning - [`6136c96`](https://github.com/AppFlowy-IO/AppFlowy/commit/6136c96c1da666db738c25f4cc37a993939ac3c2) Merge branch 'main' into feat/rename-stack-inline - [`99d2ffc`](https://github.com/AppFlowy-IO/AppFlowy/commit/99d2ffc70e2aa94fccab4b3a6a2ee020429bd227) fix: code lost after merge - [`6991259`](https://github.com/AppFlowy-IO/AppFlowy/commit/699125984f9055f65982a81492eb0479edd935a3) test: fix failing rust tests - [`ec3e619`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec3e619579e047c929c957a5fd19420cb316a999) fix: tauri localization wrong keys ### 📊 Changes **24 files changed** (+516 additions, -221 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/group/group_service.dart` (+7 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart` (+50 -36) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+66 -156) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/widgets/board_column_header.dart` (+228 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_extension.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/text_cell/text_cell_bloc.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/date_time/date_format_ext.dart` (+1 -1) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/app-dialog/ConfirmDialog.tsx` (+1 -1) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/board/BoardGroup.tsx` (+1 -1) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/layout/NestedPage/RenameDialog.tsx` (+2 -2) 📝 `frontend/resources/translations/en.json` (+2 -1) 📝 `frontend/rust-lib/event-integration/src/database_event.rs` (+2 -0) 📝 `frontend/rust-lib/event-integration/tests/database/local_test/test.rs` (+10 -3) 📝 `frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs` (+11 -2) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+11 -4) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+26 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+23 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller.rs` (+5 -0) _...and 4 more files_ </details> ### 📄 Description Enables renaming a Column/Stack inline, however in its current version only for Single- and Multi-select groups. Relates: #3703 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>