[PR #3787] [MERGED] feat:add toast in trash and confirm dialog + fix issues from launch review #5881

New issue

Closed

opened 2026-03-23 22:20:44 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3787
Author: @hyj1204
Created: 10/26/2023
Status: ✅ Merged
Merged: 11/2/2023
Merged by: @hyj1204

Base: main ← Head: feat/improve_trash_and_theme

📝 Commits (10+)

5ec2afd chore: improve trash button
79f7413 feat: improve restore all&delete all
37bf180 refactor: add showFlowyMobileConfirmDialog
949e7ed feat: add toast in delete/restore single file
97ad02b refactor: refactor to TrashActionType enum
17e7f4a fix: text invisible in signin page in dark mode
146ce0b feat: add FlowyMobileErrorStateContainer to display error state
b3aa71a refactor: add FlowyMobileStateContainer to handle empty or error state
cf9f671 refactor: unify bottom sheet style
f5e78f8 chore: unify Appbar style

📊 Changes

25 files changed (+592 additions, -572 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/application/mobile_theme_data.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+11 -6)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet.dart (+9 -146)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_action_widget.dart (+16 -30)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_add_new_page.dart (+5 -42)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_drag_handler.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_item_body.dart (+11 -6)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_item_header.dart (+17 -8)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart (+26 -25)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/default_mobile_action_pane.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+30 -22)
➖ frontend/appflowy_flutter/lib/mobile/presentation/error/error_page.dart (+0 -49)
📝 frontend/appflowy_flutter/lib/mobile/presentation/favorite/mobile_favorite_folder.dart (+17 -17)
📝 frontend/appflowy_flutter/lib/mobile/presentation/favorite/mobile_favorite_page.dart (+3 -6)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_recent_files.dart (+6 -13)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_setting_page.dart (+32 -18)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_trash_page.dart (+176 -133)
📝 frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart (+19 -15)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/personal_info_setting_group.dart (+3 -3)

...and 5 more files

📄 Description

Feature Preview

Show toast when deleting/restoring a single file in the trash
Pop up a confirm dialog when delete/restore all files in the trash(no toast here)

https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/2731a0c2-deb3-434b-a4ec-384f2160d56e

Improvement after launch review

Fix text invisible in signin page in dark mode

Add a error message page when we cannot get UserProfilePB from backend

https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/395b3fd1-cca3-4061-ad95-2b351a27cb65

Create `FlowyMobileStateContainer` to handle empty or error state content

FlowyMobileStateContainer.info

FlowyMobileStateContainer.error

It has two buttons to report issues with error messages and discord link

Unify bottom sheet style in add new page, page action, and trash action

Unify app bar style

trash page

view page

Remove the more button when the trash list is empty

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3787 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 10/26/2023 **Status:** ✅ Merged **Merged:** 11/2/2023 **Merged by:** [@hyj1204](https://github.com/hyj1204) **Base:** `main` ← **Head:** `feat/improve_trash_and_theme` --- ### 📝 Commits (10+) - [`5ec2afd`](https://github.com/AppFlowy-IO/AppFlowy/commit/5ec2afd23e3d0aaf985d7cbabf1dd8e5a6d75e24) chore: improve trash button - [`79f7413`](https://github.com/AppFlowy-IO/AppFlowy/commit/79f7413278f36be87862c48ff5927ef8e153ea3e) feat: improve restore all&delete all - [`37bf180`](https://github.com/AppFlowy-IO/AppFlowy/commit/37bf1807f80b8819a562900638a919d5bbc00cf1) refactor: add showFlowyMobileConfirmDialog - [`949e7ed`](https://github.com/AppFlowy-IO/AppFlowy/commit/949e7edd3b9e0151d196536da342b6cd4313bb5e) feat: add toast in delete/restore single file - [`97ad02b`](https://github.com/AppFlowy-IO/AppFlowy/commit/97ad02b364abeb4bee7916c88c5659566af310fe) refactor: refactor to TrashActionType enum - [`17e7f4a`](https://github.com/AppFlowy-IO/AppFlowy/commit/17e7f4a46b9a4bd0878a8932cfdf452cfa86eedc) fix: text invisible in signin page in dark mode - [`146ce0b`](https://github.com/AppFlowy-IO/AppFlowy/commit/146ce0b018f886b952dd2920ca39d8165bd84cc5) feat: add FlowyMobileErrorStateContainer to display error state - [`b3aa71a`](https://github.com/AppFlowy-IO/AppFlowy/commit/b3aa71ac1db0b8239d3246d6e5184ea65e877d78) refactor: add FlowyMobileStateContainer to handle empty or error state - [`cf9f671`](https://github.com/AppFlowy-IO/AppFlowy/commit/cf9f671e765dd591f8d762f2883d11f7d6b52c40) refactor: unify bottom sheet style - [`f5e78f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/f5e78f86d9997cce3b56f7e9ac380d5369d24654) chore: unify Appbar style ### 📊 Changes **25 files changed** (+592 additions, -572 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/application/mobile_theme_data.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+11 -6) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet.dart` (+9 -146) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_action_widget.dart` (+16 -30) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_add_new_page.dart` (+5 -42) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_drag_handler.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_item_body.dart` (+11 -6) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_item_header.dart` (+17 -8) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart` (+26 -25) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/default_mobile_action_pane.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+30 -22) ➖ `frontend/appflowy_flutter/lib/mobile/presentation/error/error_page.dart` (+0 -49) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/favorite/mobile_favorite_folder.dart` (+17 -17) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/favorite/mobile_favorite_page.dart` (+3 -6) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_recent_files.dart` (+6 -13) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_setting_page.dart` (+32 -18) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_trash_page.dart` (+176 -133) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart` (+19 -15) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/personal_info_setting_group.dart` (+3 -3) _...and 5 more files_ </details> ### 📄 Description   ### Feature Preview - Show toast when deleting/restoring a **single** file in the trash - Pop up a confirm dialog when delete/restore **all** files in the trash(no toast here) https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/2731a0c2-deb3-434b-a4ec-384f2160d56e ### Improvement after launch review <details> <summary> Fix text invisible in signin page in dark mode</summary> <img width="407" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/0e354697-58df-4e5e-bd1f-2a101c63b01d"> </details> <details> <summary> Add a error message page when we cannot get UserProfilePB from backend</summary> https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/395b3fd1-cca3-4061-ad95-2b351a27cb65 </details> <details> <summary>Create `FlowyMobileStateContainer` to handle empty or error state content</summary> <details> <summary>FlowyMobileStateContainer.info</summary> <img width="402" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/d3025f5e-b3a9-4834-92fa-78c3874ad3c7"> </details> <details> <summary> FlowyMobileStateContainer.error</summary> It has two buttons to report issues with error messages and discord link <img width="368" alt="Untitled (1)" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/da4062c6-f8f3-407b-95dc-f7d913f36716"> </details> </details> <details> <summary>Unify bottom sheet style in add new page, page action, and trash action</summary> <img width="411" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/9009c624-9e1c-4078-b085-a0d2a71f943f"> <img width="408" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/0c351d80-38cf-490b-91d1-f55d6c437cac"> <img width="398" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/d285e4c8-fd26-481b-8da3-3f7e6c85f1e3"> <img width="412" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/ec1db93f-af73-4bba-a32a-7e4743febf78"> <img width="407" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/28474b64-b7e9-4eea-8ea3-ea895282fa6e"> </details> <details> <summary>Unify app bar style</summary> **trash page** <img width="409" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/16e7ed5e-c359-4e3d-96d7-d2eb8d84a7a7"> **view page** <img width="407" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/6c7fb0e3-ae70-4ba1-bed0-7de5038976ba"> </details> <details> <summary>Remove the more button when the trash list is empty</summary> <img width="399" alt="Untitled (2)" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/327ac378-f951-4624-8060-072fc1e939f5"> </details>  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>