[PR #3814] [MERGED] fix: removed the parent padding and instead applied padding individually. #5896

New issue

Closed

opened 2026-03-23 22:20:48 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3814
Author: @Kritarthsharma
Created: 10/27/2023
Status: ✅ Merged
Merged: 10/28/2023
Merged by: @richardshiue

Base: main ← Head: fix/sidebar_divider_improvement

📝 Commits (2)

567dada fix: Removed the parent padding and instead applied individual padding to each child to ensure it doesn't affect the sidebar divider.
4c5b977 chore: Addressed comments and made changes

📊 Changes

2 files changed (+35 additions, -25 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+31 -24)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_new_page_button.dart (+4 -1)

📄 Description

Fixes #3389

The divider is now starting from the window and stretching to the edge of the Sidebar without hindering with rest of the Sidebar UI.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3814 **Author:** [@Kritarthsharma](https://github.com/Kritarthsharma) **Created:** 10/27/2023 **Status:** ✅ Merged **Merged:** 10/28/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/sidebar_divider_improvement` --- ### 📝 Commits (2) - [`567dada`](https://github.com/AppFlowy-IO/AppFlowy/commit/567dadac2650fc60166007b09b2d38a5a3e692cd) fix: Removed the parent padding and instead applied individual padding to each child to ensure it doesn't affect the sidebar divider. - [`4c5b977`](https://github.com/AppFlowy-IO/AppFlowy/commit/4c5b977b72f2011935d0bee9d6e42601dc131594) chore: Addressed comments and made changes ### 📊 Changes **2 files changed** (+35 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+31 -24) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar_new_page_button.dart` (+4 -1) </details> ### 📄 Description Fixes #3389 The divider is now starting from the window and stretching to the edge of the Sidebar without hindering with rest of the Sidebar UI. <img width="354" alt="Screenshot 2023-10-27 at 5 18 43 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/42487588/5513e553-b0a5-4ded-97a1-1561c704ba1f"> <img width="354" alt="Screenshot 2023-10-27 at 5 18 56 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/42487588/b9aa129f-fb9c-442f-8e7e-88c19875a1fa">    ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>