[PR #3817] [MERGED] refactor: hide ungrouped feature #5898

New issue

Closed

opened 2026-03-23 22:20:48 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3817
Author: @richardshiue
Created: 10/28/2023
Status: ✅ Merged
Merged: 10/29/2023
Merged by: @richardshiue

Base: main ← Head: refactor-hide-ungrouped

📝 Commits (8)

f30487e refactor: remove unused notification and listener
c825f37 revert: remove hide_ungrouped from group settings
610a160 chore: add board layout setting
3d5a0d6 chore: listen to layout settings on ui
237bf6b chore: merge remote-tracking branch 'upstream/main' into refactor-hide-ungrouped
bca0ae7 fix: duplicated group controller initialization
a957380 chore: add a tooltip to the ungrouped items button
d21808e chore: trailing comma

📊 Changes

36 files changed (+418 additions, -485 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart (+14 -51)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_view_service.dart (+7 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/group/group_listener.dart (+0 -16)
➖ frontend/appflowy_flutter/lib/plugins/database_view/application/layout/calendar_setting_listener.dart (+0 -50)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/setting/group_bloc.dart (+18 -29)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart (+19 -16)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/ungrouped_items_button.dart (+25 -19)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/application/calendar_bloc.dart (+6 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/group/database_group.dart (+17 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_button.dart (+3 -1)
📝 frontend/resources/translations/en.json (+1 -0)
➕ frontend/rust-lib/flowy-database2/src/entities/board_entities.rs (+25 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs (+1 -25)
📝 frontend/rust-lib/flowy-database2/src/entities/mod.rs (+2 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/setting_entities.rs (+48 -2)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+5 -39)
📝 frontend/rust-lib/flowy-database2/src/event_map.rs (+3 -9)
📝 frontend/rust-lib/flowy-database2/src/notification.rs (+6 -12)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+10 -42)

...and 16 more files

📄 Description

(integration test failed due to flakiness)

observable changes

group setting button state persists
fix item count bug
a tooltip on the ungrouped items button

details

remove the DidUpdateLayoutField notification and related code. It's unnecessary because the change in field_id can be easily checked for
moved hide ungrouped column flag to layout settings
add tests for updating the layout settings

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3817 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/28/2023 **Status:** ✅ Merged **Merged:** 10/29/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `refactor-hide-ungrouped` --- ### 📝 Commits (8) - [`f30487e`](https://github.com/AppFlowy-IO/AppFlowy/commit/f30487e5d9ce4c42b1cd0c609a4d79d3b3ce6f6d) refactor: remove unused notification and listener - [`c825f37`](https://github.com/AppFlowy-IO/AppFlowy/commit/c825f37465e823f482bacdf8b64ab8d53fa16608) revert: remove hide_ungrouped from group settings - [`610a160`](https://github.com/AppFlowy-IO/AppFlowy/commit/610a16004670f7125ead32d05d18adb011bc06be) chore: add board layout setting - [`3d5a0d6`](https://github.com/AppFlowy-IO/AppFlowy/commit/3d5a0d67152646f95207f27a2dcbf3b22b1e199a) chore: listen to layout settings on ui - [`237bf6b`](https://github.com/AppFlowy-IO/AppFlowy/commit/237bf6bbd8fa4d36af0656670da77f9d1aa9b571) chore: merge remote-tracking branch 'upstream/main' into refactor-hide-ungrouped - [`bca0ae7`](https://github.com/AppFlowy-IO/AppFlowy/commit/bca0ae7c43e4c9aa712e2e6e3b247249e0134c7f) fix: duplicated group controller initialization - [`a957380`](https://github.com/AppFlowy-IO/AppFlowy/commit/a957380c80d0db7ec4f28c7dfd678337182ab06d) chore: add a tooltip to the ungrouped items button - [`d21808e`](https://github.com/AppFlowy-IO/AppFlowy/commit/d21808eeade721cd0125c6000e8e33aae1ccc2ac) chore: trailing comma ### 📊 Changes **36 files changed** (+418 additions, -485 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart` (+14 -51) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_view_service.dart` (+7 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/group/group_listener.dart` (+0 -16) ➖ `frontend/appflowy_flutter/lib/plugins/database_view/application/layout/calendar_setting_listener.dart` (+0 -50) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/setting/group_bloc.dart` (+18 -29) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart` (+19 -16) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/ungrouped_items_button.dart` (+25 -19) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/application/calendar_bloc.dart` (+6 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/group/database_group.dart` (+17 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_button.dart` (+3 -1) 📝 `frontend/resources/translations/en.json` (+1 -0) ➕ `frontend/rust-lib/flowy-database2/src/entities/board_entities.rs` (+25 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs` (+1 -25) 📝 `frontend/rust-lib/flowy-database2/src/entities/mod.rs` (+2 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/setting_entities.rs` (+48 -2) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+5 -39) 📝 `frontend/rust-lib/flowy-database2/src/event_map.rs` (+3 -9) 📝 `frontend/rust-lib/flowy-database2/src/notification.rs` (+6 -12) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+10 -42) _...and 16 more files_ </details> ### 📄 Description (integration test failed due to flakiness) observable changes - group setting button state persists - fix item count bug - a tooltip on the ungrouped items button details - remove the `DidUpdateLayoutField` notification and related code. It's unnecessary because the change in `field_id` can be easily checked for - moved hide ungrouped column flag to layout settings - add tests for updating the layout settings ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>