[PR #3830] [MERGED] chore: move field width to field settings #5906

New issue

Closed

opened 2026-03-23 22:20:50 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3830
Author: @richardshiue
Created: 10/30/2023
Status: ✅ Merged
Merged: 11/6/2023
Merged by: @appflowy

Base: main ← Head: field-settings-width

📝 Commits (8)

9cae5d3 refactor: remove unnecessary builder
270ad24 feat: add width to field settings
d3f50b9 refactor: field settings logic
6ee78f1 chore: oopsies
e854a9a chore: implement UI
4a02ea1 chore: remove GridFieldCellEquatable
5364663 chore: merge remote-tracking branch 'upstream/main' into field-settings-width
4d4cbd7 test: rust-lib test fix

📊 Changes

37 files changed (+316 additions, -440 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_action_sheet_bloc.dart (+9 -7)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_cell_bloc.dart (+26 -48)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_service.dart (+0 -12)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field_settings/field_settings_service.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart (+0 -25)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/toolbar/calendar_layout_setting.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/grid_bloc.dart (+6 -27)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/layout/layout.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart (+29 -12)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell_action_sheet.dart (+40 -26)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart (+7 -14)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/row.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_property_list.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+1 -24)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/util.dart (+0 -6)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/field/field_cell_bloc_test.dart (+6 -11)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/grid_header_bloc_test.dart (+2 -1)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/util.dart (+0 -6)

...and 17 more files

📄 Description

before:

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/392e2cc8-15aa-4b0b-9ac5-b5e5fb810bd3

after

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/994dfdee-638e-455e-948e-0305b81f29da

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3830 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/30/2023 **Status:** ✅ Merged **Merged:** 11/6/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `field-settings-width` --- ### 📝 Commits (8) - [`9cae5d3`](https://github.com/AppFlowy-IO/AppFlowy/commit/9cae5d3351f6d199606adfef771fe8cade691c45) refactor: remove unnecessary builder - [`270ad24`](https://github.com/AppFlowy-IO/AppFlowy/commit/270ad24c812cd0cce5c07bbfa417be9926f096db) feat: add width to field settings - [`d3f50b9`](https://github.com/AppFlowy-IO/AppFlowy/commit/d3f50b97bd35f937212b138285f71067a1f44266) refactor: field settings logic - [`6ee78f1`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ee78f1365669d2345aed75567d597b7c3c569a7) chore: oopsies - [`e854a9a`](https://github.com/AppFlowy-IO/AppFlowy/commit/e854a9afd71b69a434f392db2b6cc2557fa551d0) chore: implement UI - [`4a02ea1`](https://github.com/AppFlowy-IO/AppFlowy/commit/4a02ea1d89004658f5c45d0aaf5548c4af9b4dd0) chore: remove GridFieldCellEquatable - [`5364663`](https://github.com/AppFlowy-IO/AppFlowy/commit/536466325e2bbb190225d5840e86ace6d09e6053) chore: merge remote-tracking branch 'upstream/main' into field-settings-width - [`4d4cbd7`](https://github.com/AppFlowy-IO/AppFlowy/commit/4d4cbd71e0636c15f0fde739298007c4895dba1b) test: rust-lib test fix ### 📊 Changes **37 files changed** (+316 additions, -440 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_action_sheet_bloc.dart` (+9 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_cell_bloc.dart` (+26 -48) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_service.dart` (+0 -12) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field_settings/field_settings_service.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart` (+0 -25) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/toolbar/calendar_layout_setting.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/grid_bloc.dart` (+6 -27) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/layout/layout.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart` (+29 -12) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell_action_sheet.dart` (+40 -26) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart` (+7 -14) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/row.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_property_list.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+1 -24) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/util.dart` (+0 -6) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/field/field_cell_bloc_test.dart` (+6 -11) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/grid_header_bloc_test.dart` (+2 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/util.dart` (+0 -6) _...and 17 more files_ </details> ### 📄 Description before: https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/392e2cc8-15aa-4b0b-9ac5-b5e5fb810bd3 after https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/994dfdee-638e-455e-948e-0305b81f29da ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>