[PR #3833] [MERGED] fix: update auto-update fields on change group #5907

New issue

Closed

opened 2026-03-23 22:20:51 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3833
Author: @zoli
Created: 10/30/2023
Status: ✅ Merged
Merged: 11/30/2023
Merged by: @appflowy

Base: main ← Head: fix/change-group

📝 Commits (10+)

12ff974 fix: update auto-update fields on change group
8a7f925 style: rust format
6f7bb70 fix: add board group test to runner
c2c4a2c fix: update auto updated fiels only when group has changed
aaff5ce fix: apply group changeset before move_row
20f0a92 fix: get from_row before move_row
1fa4c82 style: Merge branch 'main' into fix/change-group
11d26aa fix: groups method changed to get_all_groups
7698ddc style: Merge branch 'main' into fix/change-group
1ec0a2d fix: pass from group id in move group payload

📊 Changes

10 files changed (+148 additions, -55 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/board/board_group_test.dart (+50 -0)
📝 frontend/appflowy_flutter/integration_test/board/board_test_runner.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_view_service.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart (+4 -2)
📝 frontend/rust-lib/flowy-database2/src/entities/database_entities.rs (+7 -0)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+68 -31)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+1 -13)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs (+9 -7)

📄 Description

auto-update fields should get updated when moving rows from one group to another. They were getting updated only on changing row properties directly.
Also added integration test for changing row group related to #3010.

I was working on a fix for #3010, @richardshiue PR #3730 fixed part of it. This will add integration-test for #3010 and also fix auto-update fields not getting updated when changing row group.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3833 **Author:** [@zoli](https://github.com/zoli) **Created:** 10/30/2023 **Status:** ✅ Merged **Merged:** 11/30/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/change-group` --- ### 📝 Commits (10+) - [`12ff974`](https://github.com/AppFlowy-IO/AppFlowy/commit/12ff974f673fad9fb1f5def3fe40dcaac26c9f7c) fix: update auto-update fields on change group - [`8a7f925`](https://github.com/AppFlowy-IO/AppFlowy/commit/8a7f9250f39f073c85a780353ccc6a758606ea75) style: rust format - [`6f7bb70`](https://github.com/AppFlowy-IO/AppFlowy/commit/6f7bb7002ca73b78665506a175282444f7bf1774) fix: add board group test to runner - [`c2c4a2c`](https://github.com/AppFlowy-IO/AppFlowy/commit/c2c4a2cb4a9aa9dfe2bc4c943894afbc4afe061c) fix: update auto updated fiels only when group has changed - [`aaff5ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/aaff5ce5a80586c00a7722666c5ea344b999b8a4) fix: apply group changeset before move_row - [`20f0a92`](https://github.com/AppFlowy-IO/AppFlowy/commit/20f0a922b82205ec19816d80acccf00254707cb1) fix: get from_row before move_row - [`1fa4c82`](https://github.com/AppFlowy-IO/AppFlowy/commit/1fa4c82a871701471e860adcc9d5de2ab204a2b7) style: Merge branch 'main' into fix/change-group - [`11d26aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/11d26aa25c7238accae19d748ecdb6a3d8457059) fix: groups method changed to get_all_groups - [`7698ddc`](https://github.com/AppFlowy-IO/AppFlowy/commit/7698ddc6495c23458f5e4c183e34d05e0bcff6d1) style: Merge branch 'main' into fix/change-group - [`1ec0a2d`](https://github.com/AppFlowy-IO/AppFlowy/commit/1ec0a2d72861781a35d6c053b5b92b018ccb13fd) fix: pass from group id in move group payload ### 📊 Changes **10 files changed** (+148 additions, -55 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/board/board_group_test.dart` (+50 -0) 📝 `frontend/appflowy_flutter/integration_test/board/board_test_runner.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_view_service.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart` (+4 -2) 📝 `frontend/rust-lib/flowy-database2/src/entities/database_entities.rs` (+7 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+68 -31) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+1 -13) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs` (+9 -7) </details> ### 📄 Description auto-update fields should get updated when moving rows from one group to another. They were getting updated only on changing row properties directly. Also added integration test for changing row group related to #3010. I was working on a fix for #3010, @richardshiue PR #3730 fixed part of it. This will add integration-test for #3010 and also fix auto-update fields not getting updated when changing row group. #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>