[PR #3849] [MERGED] feat: support customizing page icon #5912

Closed
opened 2026-03-23 22:20:52 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3849
Author: @LucasXu0
Created: 10/31/2023
Status: Merged
Merged: 11/2/2023
Merged by: @LucasXu0

Base: mainHead: icon


📝 Commits (10+)

  • db563bb chore: don't use cache when building release package
  • 93ed50d feat: refactor icon widget design
  • acfbd5d feat: sync the emoji between page and view
  • 0546a52 feat: use cache to store the emoji data to prevent reloading
  • 750d725 feat: customize the emoji item builder
  • c281574 feat: add i18n and shuffle emoji button
  • fc7c4a9 fix: integration test
  • 568adee feat: replace emoji picker in Grid and slash menu
  • 93daa14 feat: support adding icon on mobile platform
  • f0c77ee feat: support adding and removing icon on mobile

📊 Changes

34 files changed (+1116 additions, -256 deletions)

View changed files

📝 .github/workflows/release.yml (+0 -24)
📝 frontend/appflowy_flutter/integration_test/database_row_page_test.dart (+0 -4)
📝 frontend/appflowy_flutter/integration_test/document/document_with_cover_image_test.dart (+45 -4)
📝 frontend/appflowy_flutter/integration_test/util/base.dart (+11 -3)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+9 -1)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+1 -3)
📝 frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart (+20 -3)
📝 frontend/appflowy_flutter/integration_test/util/emoji.dart (+0 -7)
📝 frontend/appflowy_flutter/integration_test/util/expectation.dart (+16 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+13 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart (+15 -5)
frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker.dart (+95 -0)
frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_header.dart (+48 -0)
frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_i18n.dart (+41 -0)
frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart (+22 -0)
frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_search_bar.dart (+156 -0)
frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_skin_tone.dart (+112 -0)
frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker.dart (+121 -0)
frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker_page.dart (+48 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_banner.dart (+6 -10)

...and 14 more files

📄 Description

Feature Preview

  • sort emoji by group
  • support changing emoji skin tone
  • add more emojis
  • customize the view icon and sync the icon between page and view
  • redesign the emoji picker

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/606ca059-0143-4803-9bac-f919e2849452

Screenshot 2023-10-31 at 22 58 53

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3849 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/31/2023 **Status:** ✅ Merged **Merged:** 11/2/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `icon` --- ### 📝 Commits (10+) - [`db563bb`](https://github.com/AppFlowy-IO/AppFlowy/commit/db563bbeb3b98c8c04b96dc82660c4774263ec2f) chore: don't use cache when building release package - [`93ed50d`](https://github.com/AppFlowy-IO/AppFlowy/commit/93ed50d213290922b5dceb7babf4ccf50f67d8df) feat: refactor icon widget design - [`acfbd5d`](https://github.com/AppFlowy-IO/AppFlowy/commit/acfbd5dc81d8688c66f272727b0a50a10ccf9137) feat: sync the emoji between page and view - [`0546a52`](https://github.com/AppFlowy-IO/AppFlowy/commit/0546a529b9f980a010c4c7e454732fe90e66471d) feat: use cache to store the emoji data to prevent reloading - [`750d725`](https://github.com/AppFlowy-IO/AppFlowy/commit/750d725e854ea5fe581b660d0754bb31125a1b93) feat: customize the emoji item builder - [`c281574`](https://github.com/AppFlowy-IO/AppFlowy/commit/c28157444af954528ad6c63760558de812701163) feat: add i18n and shuffle emoji button - [`fc7c4a9`](https://github.com/AppFlowy-IO/AppFlowy/commit/fc7c4a91ae0accc6d88ac7790cd8ec861e1658ff) fix: integration test - [`568adee`](https://github.com/AppFlowy-IO/AppFlowy/commit/568adeedc5755a9c26b24fd5cb978d55fb429cca) feat: replace emoji picker in Grid and slash menu - [`93daa14`](https://github.com/AppFlowy-IO/AppFlowy/commit/93daa144fb9f7eb09bb5e81a378903f8c020559c) feat: support adding icon on mobile platform - [`f0c77ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/f0c77ee8c199d924feb903b8a21371a44746fb8c) feat: support adding and removing icon on mobile ### 📊 Changes **34 files changed** (+1116 additions, -256 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+0 -24) 📝 `frontend/appflowy_flutter/integration_test/database_row_page_test.dart` (+0 -4) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_cover_image_test.dart` (+45 -4) 📝 `frontend/appflowy_flutter/integration_test/util/base.dart` (+11 -3) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+9 -1) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+1 -3) 📝 `frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart` (+20 -3) 📝 `frontend/appflowy_flutter/integration_test/util/emoji.dart` (+0 -7) 📝 `frontend/appflowy_flutter/integration_test/util/expectation.dart` (+16 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+13 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart` (+15 -5) ➕ `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker.dart` (+95 -0) ➕ `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_header.dart` (+48 -0) ➕ `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_i18n.dart` (+41 -0) ➕ `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart` (+22 -0) ➕ `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_search_bar.dart` (+156 -0) ➕ `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_skin_tone.dart` (+112 -0) ➕ `frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker.dart` (+121 -0) ➕ `frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker_page.dart` (+48 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_banner.dart` (+6 -10) _...and 14 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - sort emoji by group - support changing emoji skin tone - add more emojis - customize the view icon and sync the icon between page and view - redesign the emoji picker https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/606ca059-0143-4803-9bac-f919e2849452 <img width="452" alt="Screenshot 2023-10-31 at 22 58 53" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/0c0bf7e7-889b-485e-a8c9-16377234dc74"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:20:52 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5912
No description provided.