[PR #3859] [MERGED] feat: inline page reference #5917

New issue

Closed

opened 2026-03-23 22:20:54 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3859
Author: @Xazin
Created: 11/1/2023
Status: ✅ Merged
Merged: 11/3/2023
Merged by: @Xazin

Base: main ← Head: feat/inline-page-reference

📝 Commits (6)

5a8ae59 feat: more methods of inserting page reference
45c9680 test: add tests for inserting document reference
e9133f7 chore: remove unused import
4acd6d5 chore: update editor ref
b03b0ab tests: fix test with an interim solution
1214a4e Merge branch 'main' into feat/inline-page-reference

📊 Changes

16 files changed (+428 additions, -100 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/document/document_inline_page_reference_test.dart (+136 -0)
📝 frontend/appflowy_flutter/integration_test/document/document_test_runner.dart (+3 -0)
📝 frontend/appflowy_flutter/integration_test/document/document_with_inline_page_test.dart (+11 -7)
📝 frontend/appflowy_flutter/integration_test/document/edit_document_test.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+17 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart (+60 -18)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart (+6 -9)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/page_reference_commands.dart (+117 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/database/referenced_database_menu_item.dart (+22 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart (+6 -1)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_menu.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart (+19 -20)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart (+18 -40)
📝 frontend/resources/translations/en.json (+5 -1)

📄 Description

Closes: #2196 #3541 #2256

Additionally closes: #3794

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/d2159c05-dbe2-4fc0-a0f3-958a0f538b8e

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3859 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 11/1/2023 **Status:** ✅ Merged **Merged:** 11/3/2023 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/inline-page-reference` --- ### 📝 Commits (6) - [`5a8ae59`](https://github.com/AppFlowy-IO/AppFlowy/commit/5a8ae594f41ce74164aa47e712f39358a51ad025) feat: more methods of inserting page reference - [`45c9680`](https://github.com/AppFlowy-IO/AppFlowy/commit/45c968097b95943ecc21374e5d8b7e04c6cdf7c7) test: add tests for inserting document reference - [`e9133f7`](https://github.com/AppFlowy-IO/AppFlowy/commit/e9133f73be56a2fd2f6afce80ff63ae0bf042267) chore: remove unused import - [`4acd6d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/4acd6d5654ea5f57b1e7c38697a57320cbb25d85) chore: update editor ref - [`b03b0ab`](https://github.com/AppFlowy-IO/AppFlowy/commit/b03b0abe38292c3dd8ae1d7ca7dbeb2b70b6be2f) tests: fix test with an interim solution - [`1214a4e`](https://github.com/AppFlowy-IO/AppFlowy/commit/1214a4ef47de73e35f3689bb2edd90654a99a32f) Merge branch 'main' into feat/inline-page-reference ### 📊 Changes **16 files changed** (+428 additions, -100 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/document/document_inline_page_reference_test.dart` (+136 -0) 📝 `frontend/appflowy_flutter/integration_test/document/document_test_runner.dart` (+3 -0) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_inline_page_test.dart` (+11 -7) 📝 `frontend/appflowy_flutter/integration_test/document/edit_document_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+17 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart` (+60 -18) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart` (+6 -9) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/page_reference_commands.dart` (+117 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/database/referenced_database_menu_item.dart` (+22 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart` (+6 -1) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_menu.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart` (+19 -20) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart` (+18 -40) 📝 `frontend/resources/translations/en.json` (+5 -1) </details> ### 📄 Description Closes: #2196 #3541 #2256 Additionally closes: #3794 ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/d2159c05-dbe2-4fc0-a0f3-958a0f538b8e #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>