[PR #3892] [CLOSED] fix : option value in dark mode #3801 #5932

New issue

Closed

opened 2026-03-23 22:20:58 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3892
Author: @rituraj2000
Created: 11/6/2023
Status: ❌ Closed

Base: main ← Head: feat/fixCreateOptionsTextColour

📝 Commits (10+)

f10d889 fix: contrast in option value in dark mode
d544cf6 fix : removed pubspec.lock from commit
2901b70 Removed pubsprec.lock
3c28f62 minor fix
fb33cf7 reverted the changes to pubspec lock
55d9a94 reverted the changes to pubspec lock
0f35a53 minor fix
9f81d96 minor fix
98c1c48 mior fix
6f26044 mior fix

📊 Changes

11 files changed (+121 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart (+6 -1)
➕ frontend/appflowy_flutter/lib/util/color_analyzer/color_analyzer.dart (+48 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/desktop_appearance.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart (+1 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/colorscheme.dart (+2 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/dandelion.dart (+2 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart (+2 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lavender.dart (+2 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lemonade.dart (+2 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/theme_extension.dart (+5 -0)
➕ frontend/appflowy_flutter/test/unit_test/color_analyzer_test.dart (+50 -0)

📄 Description

Feature Preview

This update addresses the issue highlighted in Issue #3801.

fixes https://github.com/AppFlowy-IO/AppFlowy/issues/3801

PR Checklist

My code adheres to AppFlowy's Conventions.
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3892 **Author:** [@rituraj2000](https://github.com/rituraj2000) **Created:** 11/6/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/fixCreateOptionsTextColour` --- ### 📝 Commits (10+) - [`f10d889`](https://github.com/AppFlowy-IO/AppFlowy/commit/f10d88950d2a64f119792b6094497fff040e9a35) fix: contrast in option value in dark mode - [`d544cf6`](https://github.com/AppFlowy-IO/AppFlowy/commit/d544cf697e3be456d4accbdb7afa06bceaade3f8) fix : removed pubspec.lock from commit - [`2901b70`](https://github.com/AppFlowy-IO/AppFlowy/commit/2901b7016f34b3bb089cb15258bd1c0ac7f1a552) Removed pubsprec.lock - [`3c28f62`](https://github.com/AppFlowy-IO/AppFlowy/commit/3c28f62fe7cbd0db21a1904c2cfe406af6cd0cd9) minor fix - [`fb33cf7`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb33cf792b94d191f5a121d286ff2c13d8897a03) reverted the changes to pubspec lock - [`55d9a94`](https://github.com/AppFlowy-IO/AppFlowy/commit/55d9a942fac7b523253170223c82e46dec64f689) reverted the changes to pubspec lock - [`0f35a53`](https://github.com/AppFlowy-IO/AppFlowy/commit/0f35a53203f12634230a4875f63855569f002d5a) minor fix - [`9f81d96`](https://github.com/AppFlowy-IO/AppFlowy/commit/9f81d96df5d09370a6d0be362ad033b14d5150dc) minor fix - [`98c1c48`](https://github.com/AppFlowy-IO/AppFlowy/commit/98c1c480792d158799d9619418bacbbe2676fd4e) mior fix - [`6f26044`](https://github.com/AppFlowy-IO/AppFlowy/commit/6f26044d85593c2c6f8919559bff2ee26853df10) mior fix ### 📊 Changes **11 files changed** (+121 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart` (+6 -1) ➕ `frontend/appflowy_flutter/lib/util/color_analyzer/color_analyzer.dart` (+48 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/desktop_appearance.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart` (+1 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/colorscheme.dart` (+2 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/dandelion.dart` (+2 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart` (+2 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lavender.dart` (+2 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lemonade.dart` (+2 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/theme_extension.dart` (+5 -0) ➕ `frontend/appflowy_flutter/test/unit_test/color_analyzer_test.dart` (+50 -0) </details> ### 📄 Description ### Feature Preview ![Preview : Before | After](https://github.com/AppFlowy-IO/AppFlowy/assets/83244005/1420e48c-8fb1-4ce6-ba69-40fc1d6080e3) This update addresses the issue highlighted in [Issue #3801](https://github.com/AppFlowy-IO/AppFlowy/issues/3801). fixes https://github.com/AppFlowy-IO/AppFlowy/issues/3801 --- #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions). - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>