[PR #3893] [MERGED] feat: show notes icon when notes is not empty #5933

New issue

Closed

opened 2026-03-23 22:20:58 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3893
Author: @Xazin
Created: 11/6/2023
Status: ✅ Merged
Merged: 11/8/2023
Merged by: @Xazin

Base: main ← Head: feat/support-notes-icon

📝 Commits (4)

84decc2 feat: show notes icon when notes is not empty
0618436 fix: redundant clone
f30da1a chore: Merge remote-tracking branch 'upstream/main' into feat/support-notes-icon
16c221c chore: update collab and fix after merging main

📊 Changes

19 files changed (+250 additions, -157 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/application/row/row_service.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/ungrouped_items_button.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_document_bloc.dart (+11 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart (+37 -37)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_bloc.dart (+26 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_cell_builder.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/text_card_cell.dart (+28 -19)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_detail.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_document.dart (+55 -45)
📝 frontend/appflowy_flutter/lib/plugins/document/application/doc_bloc.dart (+13 -9)
📝 frontend/appflowy_tauri/src-tauri/Cargo.lock (+12 -12)
📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+8 -8)
➕ frontend/resources/flowy_icons/16x/notes.svg (+11 -0)
📝 frontend/rust-lib/Cargo.lock (+10 -10)
📝 frontend/rust-lib/Cargo.toml (+8 -8)
📝 frontend/rust-lib/event-integration/tests/database/local_test/test.rs (+2 -0)
📝 frontend/rust-lib/flowy-database2/src/entities/row_entities.rs (+10 -0)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+3 -1)

📄 Description

Closes: #3522
Relates: https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/118

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/e0ae6ec0-4a96-4d18-9518-ee4b7de5d5dc

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3893 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 11/6/2023 **Status:** ✅ Merged **Merged:** 11/8/2023 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `feat/support-notes-icon` --- ### 📝 Commits (4) - [`84decc2`](https://github.com/AppFlowy-IO/AppFlowy/commit/84decc2395d266525f2b7b6bae399dec496bd942) feat: show notes icon when notes is not empty - [`0618436`](https://github.com/AppFlowy-IO/AppFlowy/commit/0618436e8dea127f0e92e8698beb54363fbba485) fix: redundant clone - [`f30da1a`](https://github.com/AppFlowy-IO/AppFlowy/commit/f30da1a43908189104ca8685d4e4b63eac14e525) chore: Merge remote-tracking branch 'upstream/main' into feat/support-notes-icon - [`16c221c`](https://github.com/AppFlowy-IO/AppFlowy/commit/16c221c65b0a8a9a103a18c1e33c655653f72eee) chore: update collab and fix after merging main ### 📊 Changes **19 files changed** (+250 additions, -157 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/row/row_service.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/ungrouped_items_button.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_document_bloc.dart` (+11 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart` (+37 -37) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_bloc.dart` (+26 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_cell_builder.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/text_card_cell.dart` (+28 -19) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_detail.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_document.dart` (+55 -45) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/doc_bloc.dart` (+13 -9) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.lock` (+12 -12) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+8 -8) ➕ `frontend/resources/flowy_icons/16x/notes.svg` (+11 -0) 📝 `frontend/rust-lib/Cargo.lock` (+10 -10) 📝 `frontend/rust-lib/Cargo.toml` (+8 -8) 📝 `frontend/rust-lib/event-integration/tests/database/local_test/test.rs` (+2 -0) 📝 `frontend/rust-lib/flowy-database2/src/entities/row_entities.rs` (+10 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+3 -1) </details> ### 📄 Description Closes: #3522 Relates: https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/118 ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/e0ae6ec0-4a96-4d18-9518-ee4b7de5d5dc #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>