[PR #3894] [MERGED] feat: adjust toggle list, callout, quote and divider on mobile #5934

New issue

Closed

opened 2026-03-23 22:20:58 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3894
Author: @LucasXu0
Created: 11/7/2023
Status: ✅ Merged
Merged: 11/8/2023
Merged by: @LucasXu0

Base: main ← Head: toggle_list

📝 Commits (5)

4b9dbb4 feat: adjust toggle list block
404688d feat: show block actions when tapping divider
6861495 feat: add toggle list and callout to toolbar
2093cc3 feat: refactor the emoji picker button
1a1072b fix: toggle list integration tests

📊 Changes

20 files changed (+308 additions, -108 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/document/document_with_toggle_list_test.dart (+16 -7)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart (+5 -6)
📝 frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker.dart (+23 -3)
📝 frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker_page.dart (+3 -11)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart (+13 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/mobile_block_action_buttons.dart (+11 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/emoji_picker_button.dart (+49 -26)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/callout/callout_block_component.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/error/error_block_component_builder.dart (+19 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart (+20 -24)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/math_equation/mobile_math_equation_toolbar_item.dart (+0 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_item/list_mobile_toolbar_item.dart (+121 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart (+10 -6)
📝 frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart (+2 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+2 -2)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+2 -1)
📝 frontend/resources/translations/en.json (+6 -1)

📄 Description

Feature Preview

adjusts toggle list, callout, quote on mobile
supports more list block toolbar item

adjusts unsupported block on mobile
adjusts divider on mobile

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3894 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/7/2023 **Status:** ✅ Merged **Merged:** 11/8/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `toggle_list` --- ### 📝 Commits (5) - [`4b9dbb4`](https://github.com/AppFlowy-IO/AppFlowy/commit/4b9dbb442ca0b60a488bc1440d7cd7839789e75e) feat: adjust toggle list block - [`404688d`](https://github.com/AppFlowy-IO/AppFlowy/commit/404688d90182a0144ad3504fe3ec4c702472768c) feat: show block actions when tapping divider - [`6861495`](https://github.com/AppFlowy-IO/AppFlowy/commit/6861495c3fbbefe2e68837f91648e69b711c46e7) feat: add toggle list and callout to toolbar - [`2093cc3`](https://github.com/AppFlowy-IO/AppFlowy/commit/2093cc30282be1c4ea674b7519ce1dc5087f48ba) feat: refactor the emoji picker button - [`1a1072b`](https://github.com/AppFlowy-IO/AppFlowy/commit/1a1072bfe6b4103feb4213bb3d319a2b97e6a82e) fix: toggle list integration tests ### 📊 Changes **20 files changed** (+308 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/document/document_with_toggle_list_test.dart` (+16 -7) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker_screen.dart` (+5 -6) 📝 `frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker.dart` (+23 -3) 📝 `frontend/appflowy_flutter/lib/plugins/base/icon/icon_picker_page.dart` (+3 -11) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart` (+13 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/mobile_block_action_buttons.dart` (+11 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/emoji_picker_button.dart` (+49 -26) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/callout/callout_block_component.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/error/error_block_component_builder.dart` (+19 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart` (+20 -24) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/math_equation/mobile_math_equation_toolbar_item.dart` (+0 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_item/list_mobile_toolbar_item.dart` (+121 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart` (+10 -6) 📝 `frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart` (+2 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+2 -1) 📝 `frontend/resources/translations/en.json` (+6 -1) </details> ### 📄 Description   ### Feature Preview - adjusts toggle list, callout, quote on mobile - supports more list block toolbar item <img width="543" alt="Screenshot 2023-11-07 at 17 27 09" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/75c49c9d-b046-4409-857b-6b37e04d86aa"> - adjusts unsupported block on mobile <img width="443" alt="Screenshot 2023-11-07 at 17 09 31" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/72d128a2-fe30-47cf-9287-de7d21d245f5"> - adjusts divider on mobile  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>