[PR #3898] [MERGED] feat: display the titles of a view's ancestors and the view's title on the title bar. #5937

New issue

Closed

opened 2026-03-23 22:20:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3898
Author: @LucasXu0
Created: 11/8/2023
Status: ✅ Merged
Merged: 11/9/2023
Merged by: @LucasXu0

Base: main ← Head: view_title

📝 Commits (6)

dd17e97 feat: add no pages inside tips
ec92770 feat: show view's ancestors (include itself) title on bar
bac2467 feat: show view's ancestors (include itself) title on bar
a3d5b8f Merge branch 'main' into view_title
53fb2d9 test: add integration tests
d9f67c9 fix: integration tests

📊 Changes

15 files changed (+507 additions, -70 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/document/document_with_cover_image_test.dart (+6 -1)
📝 frontend/appflowy_flutter/integration_test/sidebar/sidebar_favorites_test.dart (+7 -17)
➕ frontend/appflowy_flutter/integration_test/sidebar/sidebar_icon_test.dart (+76 -0)
📝 frontend/appflowy_flutter/integration_test/sidebar/sidebar_test_runner.dart (+3 -1)
📝 frontend/appflowy_flutter/integration_test/util/common_operations.dart (+44 -0)
📝 frontend/appflowy_flutter/integration_test/util/emoji.dart (+5 -1)
📝 frontend/appflowy_flutter/integration_test/util/expectation.dart (+24 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/tar_bar/tab_bar_view.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/document.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/emoji_picker_button.dart (+27 -13)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart (+19 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+45 -23)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/left_bar_item.dart (+5 -3)
➕ frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart (+236 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart (+5 -3)

📄 Description

Feature Preview

support editing the title and icon on the title bar
show the icon and title on the title bar
show the view's ancestors

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/4e8be3a6-8820-45f1-870d-c033514b590f

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3898 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/8/2023 **Status:** ✅ Merged **Merged:** 11/9/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `view_title` --- ### 📝 Commits (6) - [`dd17e97`](https://github.com/AppFlowy-IO/AppFlowy/commit/dd17e971ed77e8344b306ecdcc91fe052dc7a6fa) feat: add no pages inside tips - [`ec92770`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec9277055c8ad8f46616585a58324a1a0177121d) feat: show view's ancestors (include itself) title on bar - [`bac2467`](https://github.com/AppFlowy-IO/AppFlowy/commit/bac24674b61507ff8218f5ddac9eb84bc0383e7f) feat: show view's ancestors (include itself) title on bar - [`a3d5b8f`](https://github.com/AppFlowy-IO/AppFlowy/commit/a3d5b8fcab8d18fd342fa574db1358645df76eb1) Merge branch 'main' into view_title - [`53fb2d9`](https://github.com/AppFlowy-IO/AppFlowy/commit/53fb2d90468d96218ebfc90f793ad73d92b10f50) test: add integration tests - [`d9f67c9`](https://github.com/AppFlowy-IO/AppFlowy/commit/d9f67c96c24f94f459542a64e3afe1fd41b6d5be) fix: integration tests ### 📊 Changes **15 files changed** (+507 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/document/document_with_cover_image_test.dart` (+6 -1) 📝 `frontend/appflowy_flutter/integration_test/sidebar/sidebar_favorites_test.dart` (+7 -17) ➕ `frontend/appflowy_flutter/integration_test/sidebar/sidebar_icon_test.dart` (+76 -0) 📝 `frontend/appflowy_flutter/integration_test/sidebar/sidebar_test_runner.dart` (+3 -1) 📝 `frontend/appflowy_flutter/integration_test/util/common_operations.dart` (+44 -0) 📝 `frontend/appflowy_flutter/integration_test/util/emoji.dart` (+5 -1) 📝 `frontend/appflowy_flutter/integration_test/util/expectation.dart` (+24 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/tar_bar/tab_bar_view.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/document.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/emoji_picker_button.dart` (+27 -13) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart` (+19 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+45 -23) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/left_bar_item.dart` (+5 -3) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart` (+236 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart` (+5 -3) </details> ### 📄 Description   ### Feature Preview - support editing the title and icon on the title bar - show the icon and title on the title bar - show the view's ancestors <img width="870" alt="Screenshot 2023-11-08 at 17 41 22" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/afbadc81-a221-415e-9f1d-f3a958afeb1e"> https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/4e8be3a6-8820-45f1-870d-c033514b590f  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>