[PR #3903] [MERGED] fix: notifications setting #5939

New issue

Closed

opened 2026-03-23 22:20:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:20:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3903
Author: @Xazin
Created: 11/8/2023
Status: ✅ Merged
Merged: 11/8/2023
Merged by: @Xazin

Base: main ← Head: fix/notification-settings

📝 Commits (3)

3bcc4a9 fix: notifications setting
10af5c1 fix: remove dependency in reminder bloc
b653893 test: remove redundant lines

📊 Changes

6 files changed (+64 additions, -22 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/runner.dart (+2 -4)
➕ frontend/appflowy_flutter/integration_test/settings/notifications_settings_test.dart (+41 -0)
➕ frontend/appflowy_flutter/integration_test/settings/settings_runner.dart (+13 -0)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+1 -8)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/user/application/reminder/reminder_bloc.dart (+6 -9)

📄 Description

Closes: #3846

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/f5c82f4d-af6f-41ad-ad32-a2e366788894

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3903 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 11/8/2023 **Status:** ✅ Merged **Merged:** 11/8/2023 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/notification-settings` --- ### 📝 Commits (3) - [`3bcc4a9`](https://github.com/AppFlowy-IO/AppFlowy/commit/3bcc4a9750916495c6426632fdf3eba5159b6edb) fix: notifications setting - [`10af5c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/10af5c1a40a4d8c15a81fd31813de0bbb3b6f0af) fix: remove dependency in reminder bloc - [`b653893`](https://github.com/AppFlowy-IO/AppFlowy/commit/b653893c5c0229371073bcffbb524c79a471a23e) test: remove redundant lines ### 📊 Changes **6 files changed** (+64 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+2 -4) ➕ `frontend/appflowy_flutter/integration_test/settings/notifications_settings_test.dart` (+41 -0) ➕ `frontend/appflowy_flutter/integration_test/settings/settings_runner.dart` (+13 -0) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+1 -8) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/user/application/reminder/reminder_bloc.dart` (+6 -9) </details> ### 📄 Description Closes: #3846 ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/f5c82f4d-af6f-41ad-ad32-a2e366788894 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>