[PR #3925] [MERGED] feat: delete kanban board groups #5952

Closed
opened 2026-03-23 22:21:03 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3925
Author: @richardshiue
Created: 11/13/2023
Status: Merged
Merged: 11/28/2023
Merged by: @appflowy

Base: mainHead: delete-group


📝 Commits (10+)

  • 0ba13c1 feat: hide/unhide ui
  • 49a7a8a chore: implement collapsible side bar and adjust group header (#2)
  • 926e97e refactor: hidden columns into own file
  • 17cdd79 chore: adjust new group button position
  • 503e617 fix: flowy icon buton secondary color bleed
  • c57e986 chore: some UI adjustments
  • 4d9a87c fix: some regressions
  • b0c566e chore: proper group is_visible fetching
  • 97b2d85 chore: use a bloc to manage hidden groups
  • e6ca940 fix: hiding groups not working

📊 Changes

28 files changed (+476 additions, -187 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/board/board_hide_groups_test.dart (+44 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/group/group_service.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/widgets/board_column_header.dart (+33 -18)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/widgets/board_hidden_groups.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_extension.dart (+9 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/text_card_cell.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart (+1 -0)
📝 frontend/resources/translations/en.json (+4 -2)
📝 frontend/rust-lib/event-integration/src/database_event.rs (+12 -0)
📝 frontend/rust-lib/event-integration/tests/database/local_test/group_test.rs (+156 -0)
📝 frontend/rust-lib/event-integration/tests/database/local_test/test.rs (+0 -134)
📝 frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs (+30 -8)
📝 frontend/rust-lib/flowy-database2/src/entities/view_entities.rs (+4 -0)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+12 -0)
📝 frontend/rust-lib/flowy-database2/src/event_map.rs (+4 -0)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+14 -6)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+39 -4)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_operation.rs (+3 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_type_option.rs (+2 -5)

...and 8 more files

📄 Description

fixes #1822

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/c2573c38-6637-451e-a0fe-013f87fb8e41

  • button in option
  • confirmation dialog
  • rust-lib test and integration test

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3925 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/13/2023 **Status:** ✅ Merged **Merged:** 11/28/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `delete-group` --- ### 📝 Commits (10+) - [`0ba13c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/0ba13c180ab60ad0fc81552ad19041bb7c1af162) feat: hide/unhide ui - [`49a7a8a`](https://github.com/AppFlowy-IO/AppFlowy/commit/49a7a8a9923dfb93e6061408d8dd8a55438b0bb6) chore: implement collapsible side bar and adjust group header (#2) - [`926e97e`](https://github.com/AppFlowy-IO/AppFlowy/commit/926e97e46b0173e33ede7eb802a7ced58054efe7) refactor: hidden columns into own file - [`17cdd79`](https://github.com/AppFlowy-IO/AppFlowy/commit/17cdd799e00a608a936addb1cd4fe1b3503fc04c) chore: adjust new group button position - [`503e617`](https://github.com/AppFlowy-IO/AppFlowy/commit/503e6176f1d1c5b1c15f9f57677c459e8cc3e5ab) fix: flowy icon buton secondary color bleed - [`c57e986`](https://github.com/AppFlowy-IO/AppFlowy/commit/c57e9860509805982fdb570c3864bc9e65e37d90) chore: some UI adjustments - [`4d9a87c`](https://github.com/AppFlowy-IO/AppFlowy/commit/4d9a87c1f88357a04d8dd31976ea2f98441c08a4) fix: some regressions - [`b0c566e`](https://github.com/AppFlowy-IO/AppFlowy/commit/b0c566e6e66013a72c40df0cf3952b7ba38fdf78) chore: proper group is_visible fetching - [`97b2d85`](https://github.com/AppFlowy-IO/AppFlowy/commit/97b2d85a7245a7113c76b9eb035c75659a44b71e) chore: use a bloc to manage hidden groups - [`e6ca940`](https://github.com/AppFlowy-IO/AppFlowy/commit/e6ca940597554110a7b7e5f1a6225e6ea7ea32be) fix: hiding groups not working ### 📊 Changes **28 files changed** (+476 additions, -187 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/board/board_hide_groups_test.dart` (+44 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/group/group_service.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/widgets/board_column_header.dart` (+33 -18) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/widgets/board_hidden_groups.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_extension.dart` (+9 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/text_card_cell.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart` (+1 -0) 📝 `frontend/resources/translations/en.json` (+4 -2) 📝 `frontend/rust-lib/event-integration/src/database_event.rs` (+12 -0) 📝 `frontend/rust-lib/event-integration/tests/database/local_test/group_test.rs` (+156 -0) 📝 `frontend/rust-lib/event-integration/tests/database/local_test/test.rs` (+0 -134) 📝 `frontend/rust-lib/flowy-database2/src/entities/group_entities/group.rs` (+30 -8) 📝 `frontend/rust-lib/flowy-database2/src/entities/view_entities.rs` (+4 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+12 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_map.rs` (+4 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+14 -6) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+39 -4) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_operation.rs` (+3 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_type_option.rs` (+2 -5) _...and 8 more files_ </details> ### 📄 Description fixes #1822 https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/c2573c38-6637-451e-a0fe-013f87fb8e41 - [x] button in option - [x] confirmation dialog - [x] rust-lib test and integration test ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:03 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5952
No description provided.