[PR #3929] [MERGED] fix: padding issue with the select tags #5953

New issue

Closed

opened 2026-03-23 22:21:03 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3929
Author: @richardshiue
Created: 11/13/2023
Status: ✅ Merged
Merged: 11/13/2023
Merged by: @richardshiue

Base: main ← Head: fix-select-option-text

📝 Commits (2)

f78214d fix: padding issue with the select tags
daeb19d chore: better solution from Lucas

📊 Changes

2 files changed (+10 additions, -8 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart (+2 -4)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart (+8 -4)

📄 Description

FlowyText has a special behavior with the TextHeightBehavior. Also bump the vertical padding from 1.5 to 2.0

Before

After

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3929 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/13/2023 **Status:** ✅ Merged **Merged:** 11/13/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix-select-option-text` --- ### 📝 Commits (2) - [`f78214d`](https://github.com/AppFlowy-IO/AppFlowy/commit/f78214d28f4225f3c6cc2e23659f1284ff4cd767) fix: padding issue with the select tags - [`daeb19d`](https://github.com/AppFlowy-IO/AppFlowy/commit/daeb19d57e375f57666bfbef5290ae3a06978f3c) chore: better solution from Lucas ### 📊 Changes **2 files changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart` (+2 -4) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart` (+8 -4) </details> ### 📄 Description `FlowyText` has a special behavior with the `TextHeightBehavior`. Also bump the vertical padding from 1.5 to 2.0 Before ![Screenshot 2023-11-13 at 6 04 18 PM](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/a725f662-628c-406e-ad9c-dabf91c89be0) After ![Screenshot 2023-11-13 at 6 04 01 PM](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/307ee959-5958-4220-8a67-74c011871726) ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>