[PR #3947] [MERGED] feat: keep the toolbar the same height as the keyboard to optimize the editing experience. #5965

Closed
opened 2026-03-23 22:21:07 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3947
Author: @LucasXu0
Created: 11/16/2023
Status: Merged
Merged: 11/17/2023
Merged by: @LucasXu0

Base: mainHead: optimize_mobile_editing


📝 Commits (10+)

  • ab61510 feat: integrate the new mobile toolbar
  • c20a89d feat: add add block menu item
  • d177f29 feat: add convert to block item menu
  • 2faa1b9 feat: close menu after inserting block
  • ff81553 feat: click empty area will focus on the last paragraph
  • fd825d8 fix: align the icon and title on mobile
  • 06b9605 fix: emoji picker overflow on small screen phone
  • 051e5c7 chore: rename router
  • ebb1a84 feat: add language settings page
  • 4131e43 chore: clean up router

📊 Changes

67 files changed (+1728 additions, -483 deletions)

View changed files

📝 frontend/appflowy_flutter/ios/Podfile.lock (+6 -0)
📝 frontend/appflowy_flutter/lib/mobile/application/mobile_theme_data.dart (+8 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_action_widget.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart (+67 -65)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_setting_page.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_trash_page.dart (+1 -1)
frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/appearance_setting_group.dart (+23 -0)
frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/theme_setting.dart (+90 -0)
frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance_setting_group.dart (+0 -110)
frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_picker_screen.dart (+127 -0)
frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_setting.dart (+47 -0)
frontend/appflowy_flutter/lib/mobile/presentation/setting/language/language_picker_screen.dart (+83 -0)
frontend/appflowy_flutter/lib/mobile/presentation/setting/language_setting_group.dart (+64 -0)
frontend/appflowy_flutter/lib/mobile/presentation/setting/logout_setting_group.dart (+38 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/setting.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/widgets/mobile_setting_group_widget.dart (+6 -12)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/widgets/mobile_setting_item_widget.dart (+4 -4)
frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_search_bar.dart (+77 -0)
📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker.dart (+3 -0)

...and 47 more files

📄 Description

Feature Preview

before

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/41f3ee66-712a-4bb6-a4ca-e8c222d0f747

after

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/6862afd1-47fc-4097-b129-ad2dfdc3e853


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3947 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/16/2023 **Status:** ✅ Merged **Merged:** 11/17/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `optimize_mobile_editing` --- ### 📝 Commits (10+) - [`ab61510`](https://github.com/AppFlowy-IO/AppFlowy/commit/ab61510500a2a5b568d0620cf45c952b13182f72) feat: integrate the new mobile toolbar - [`c20a89d`](https://github.com/AppFlowy-IO/AppFlowy/commit/c20a89d2f84cbbb0612ff8ae9edca83b465a6acf) feat: add add block menu item - [`d177f29`](https://github.com/AppFlowy-IO/AppFlowy/commit/d177f29a55e7f57f636d68985fa015634e8b0774) feat: add convert to block item menu - [`2faa1b9`](https://github.com/AppFlowy-IO/AppFlowy/commit/2faa1b9333ff3d1ff33849373d833769c341d2fe) feat: close menu after inserting block - [`ff81553`](https://github.com/AppFlowy-IO/AppFlowy/commit/ff81553859dc88cf7993ec3d288b7a7aa08ac4ba) feat: click empty area will focus on the last paragraph - [`fd825d8`](https://github.com/AppFlowy-IO/AppFlowy/commit/fd825d83ff26c89d61da981a1063e06adec93631) fix: align the icon and title on mobile - [`06b9605`](https://github.com/AppFlowy-IO/AppFlowy/commit/06b96058b239d77f7b1238bf1af2d2a1fb1671da) fix: emoji picker overflow on small screen phone - [`051e5c7`](https://github.com/AppFlowy-IO/AppFlowy/commit/051e5c79460d754e7eff5c20642e0045667f7c37) chore: rename router - [`ebb1a84`](https://github.com/AppFlowy-IO/AppFlowy/commit/ebb1a84852c4aeb24de3671edee5626bad9bd3cd) feat: add language settings page - [`4131e43`](https://github.com/AppFlowy-IO/AppFlowy/commit/4131e43d389ef73832f53fb4affef35467b6f300) chore: clean up router ### 📊 Changes **67 files changed** (+1728 additions, -483 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/ios/Podfile.lock` (+6 -0) 📝 `frontend/appflowy_flutter/lib/mobile/application/mobile_theme_data.dart` (+8 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_action_widget.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart` (+67 -65) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_setting_page.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_trash_page.dart` (+1 -1) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/appearance_setting_group.dart` (+23 -0) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/theme_setting.dart` (+90 -0) ➖ `frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance_setting_group.dart` (+0 -110) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_picker_screen.dart` (+127 -0) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_setting.dart` (+47 -0) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/setting/language/language_picker_screen.dart` (+83 -0) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/setting/language_setting_group.dart` (+64 -0) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/setting/logout_setting_group.dart` (+38 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/setting.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/widgets/mobile_setting_group_widget.dart` (+6 -12) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/widgets/mobile_setting_item_widget.dart` (+4 -4) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_search_bar.dart` (+77 -0) 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_picker.dart` (+3 -0) _...and 47 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview #### before https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/41f3ee66-712a-4bb6-a4ca-e8c222d0f747 #### after https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/6862afd1-47fc-4097-b129-ad2dfdc3e853 <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:07 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5965
No description provided.