[PR #3957] [MERGED] refactor: use dependency injection to adapt the theme on mobile. #5972

New issue

Closed

opened 2026-03-23 22:21:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3957
Author: @LucasXu0
Created: 11/17/2023
Status: ✅ Merged
Merged: 11/20/2023
Merged by: @LucasXu0

Base: main ← Head: refactor_theme_data

📝 Commits (6)

e23c221 refactor: theme data
5a54b4b Merge branch 'main' into refactor_theme_data
3b9b352 fix: gst
193a1b3 fix: the cover icon is invisible in dark mode
0ae12dc chore: minor UI update
c1ec4d1 feat: adjust toolbar theme in dark mode

📊 Changes

14 files changed (+599 additions, -551 deletions)

View changed files

➖ frontend/appflowy_flutter/lib/mobile/application/mobile_theme_data.dart (+0 -275)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/recent_folder/mobile_recent_view.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart (+16 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+7 -13)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_item/mobile_text_decoration_item.dart (+5 -2)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+9 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart (+7 -252)
➕ frontend/appflowy_flutter/lib/workspace/application/settings/appearance/base_appearance.dart (+107 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/settings/appearance/desktop_appearance.dart (+150 -0)
➕ frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart (+282 -0)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3957 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/17/2023 **Status:** ✅ Merged **Merged:** 11/20/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `refactor_theme_data` --- ### 📝 Commits (6) - [`e23c221`](https://github.com/AppFlowy-IO/AppFlowy/commit/e23c221c09afb867c117441927c9047e44e71248) refactor: theme data - [`5a54b4b`](https://github.com/AppFlowy-IO/AppFlowy/commit/5a54b4b3b866effe7ec5a7b15d44c046c752c696) Merge branch 'main' into refactor_theme_data - [`3b9b352`](https://github.com/AppFlowy-IO/AppFlowy/commit/3b9b352ecc07b14e0f0f17908eda73a0a17ce777) fix: gst - [`193a1b3`](https://github.com/AppFlowy-IO/AppFlowy/commit/193a1b35877c8c3df9e3820896a5c5edd725088c) fix: the cover icon is invisible in dark mode - [`0ae12dc`](https://github.com/AppFlowy-IO/AppFlowy/commit/0ae12dc5411f8ac863cd0d38170eb68d16e2a1a3) chore: minor UI update - [`c1ec4d1`](https://github.com/AppFlowy-IO/AppFlowy/commit/c1ec4d12b7d5b94cb5591c8d21be0925b20dac3e) feat: adjust toolbar theme in dark mode ### 📊 Changes **14 files changed** (+599 additions, -551 deletions) <details> <summary>View changed files</summary> ➖ `frontend/appflowy_flutter/lib/mobile/application/mobile_theme_data.dart` (+0 -275) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/recent_folder/mobile_recent_view.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart` (+16 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+7 -13) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_item/mobile_text_decoration_item.dart` (+5 -2) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+9 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart` (+7 -252) ➕ `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/base_appearance.dart` (+107 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/desktop_appearance.dart` (+150 -0) ➕ `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart` (+282 -0) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) </details> ### 📄 Description   ### Feature Preview <img width="543" alt="Screenshot 2023-11-17 at 16 09 37" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/7f64aace-99b3-4722-8ab5-2404b418b3a3"> <img width="543" alt="Screenshot 2023-11-17 at 16 10 13" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/a448c708-a903-449c-ae54-f43655327259"> <img width="543" alt="Screenshot 2023-11-17 at 16 54 33" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/d0fb1484-e7a5-416d-ba53-c976b12d0c44">  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>