[PR #3958] [MERGED] feat: rtl toolbar item setting #5973

New issue

Closed

opened 2026-03-23 22:21:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/3958
Author: @zoli
Created: 11/17/2023
Status: ✅ Merged
Merged: 2/28/2024
Merged by: @LucasXu0

Base: main ← Head: feat/rtl-toolbar-setting

📝 Commits (7)

1e15a91 feat: rtl toolbar item setting
3982185 style: fix flutter analyze
4c41ae1 fix: adapt integration test to new feature
8ce4cc2 style: fix flutter analyze
9f73da9 test: mark key visible for testing
c8bba6f style: Merge branch 'main' into feat/rtl-toolbar-setting
62bcf8b Merge branch 'main' into feat/rtl-toolbar-setting

📊 Changes

8 files changed (+66 additions, -35 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/document/document_text_direction_test.dart (+3 -4)
📝 frontend/appflowy_flutter/integration_test/util/settings.dart (+7 -24)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/direction_setting.dart (+32 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+1 -0)
📝 frontend/resources/translations/en.json (+2 -1)
📝 frontend/rust-lib/flowy-user/src/entities/user_setting.rs (+6 -0)

📄 Description

Enable or disable RTL toolbar items through settings. Currently, they are only enabled when the default text direction setting is set to RTL. This separates the option to an independent setting.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/3958 **Author:** [@zoli](https://github.com/zoli) **Created:** 11/17/2023 **Status:** ✅ Merged **Merged:** 2/28/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/rtl-toolbar-setting` --- ### 📝 Commits (7) - [`1e15a91`](https://github.com/AppFlowy-IO/AppFlowy/commit/1e15a91a488776ba52569bdf0a0fc9d8d109ab95) feat: rtl toolbar item setting - [`3982185`](https://github.com/AppFlowy-IO/AppFlowy/commit/39821853172aac2bf8a1d8a77c2cd59e3b8f0729) style: fix flutter analyze - [`4c41ae1`](https://github.com/AppFlowy-IO/AppFlowy/commit/4c41ae18d9472e3aa0dff1112fa04e7c550bbc6c) fix: adapt integration test to new feature - [`8ce4cc2`](https://github.com/AppFlowy-IO/AppFlowy/commit/8ce4cc28ee96baf3ed0fa77ff3d6ec9c2f602304) style: fix flutter analyze - [`9f73da9`](https://github.com/AppFlowy-IO/AppFlowy/commit/9f73da9c9d5313706abf609a41f8f84247e8b643) test: mark key visible for testing - [`c8bba6f`](https://github.com/AppFlowy-IO/AppFlowy/commit/c8bba6f6006eb287bd89fd9b00e71885411fa27c) style: Merge branch 'main' into feat/rtl-toolbar-setting - [`62bcf8b`](https://github.com/AppFlowy-IO/AppFlowy/commit/62bcf8b16efc45ba2c9c782a6f5af1b5c8bb2896) Merge branch 'main' into feat/rtl-toolbar-setting ### 📊 Changes **8 files changed** (+66 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/document/document_text_direction_test.dart` (+3 -4) 📝 `frontend/appflowy_flutter/integration_test/util/settings.dart` (+7 -24) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/direction_setting.dart` (+32 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+1 -0) 📝 `frontend/resources/translations/en.json` (+2 -1) 📝 `frontend/rust-lib/flowy-user/src/entities/user_setting.rs` (+6 -0) </details> ### 📄 Description Enable or disable RTL toolbar items through settings. Currently, they are only enabled when the default text direction setting is set to RTL. This separates the option to an independent setting. #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>