[PR #4003] [MERGED] chore: fix the select option mouse event conflict #5996

Closed
opened 2026-03-23 22:21:15 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4003
Author: @richardshiue
Created: 11/24/2023
Status: Merged
Merged: 11/24/2023
Merged by: @richardshiue

Base: mainHead: fix-select-option


📝 Commits (2)

  • cc5d3ef chore: fix this hot mess
  • f566232 chore: improve create option

📊 Changes

6 files changed (+84 additions, -91 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart (+7 -7)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/multi_select.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart (+12 -23)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/single_select.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart (+19 -24)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_editor.dart (+42 -33)

📄 Description

fixes #4002

also includes some code cleanup

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4003 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/24/2023 **Status:** ✅ Merged **Merged:** 11/24/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix-select-option` --- ### 📝 Commits (2) - [`cc5d3ef`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc5d3efaec596cb6377bd2f58bede818b1b218c3) chore: fix this hot mess - [`f566232`](https://github.com/AppFlowy-IO/AppFlowy/commit/f56623249e399b844728c50888ee3f6aee74bd99) chore: improve create option ### 📊 Changes **6 files changed** (+84 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart` (+7 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/multi_select.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option.dart` (+12 -23) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/single_select.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/extension.dart` (+19 -24) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_editor.dart` (+42 -33) </details> ### 📄 Description fixes #4002 also includes some code cleanup ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:15 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5996
No description provided.