[PR #4022] [MERGED] feat: insert a new field to the left or right of an existing one #6005

New issue

Closed

opened 2026-03-23 22:21:17 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4022
Author: @richardshiue
Created: 11/27/2023
Status: ✅ Merged
Merged: 11/28/2023
Merged by: @appflowy

Base: main ← Head: insert-field-left-right

📝 Commits (10+)

899e83a feat: allow inserting fields before or after a certain field
abe8f94 fix: tauri build
b6d3fd9 chore: implement frontend
a945ff6 test: rust-lib tests
778dc0a test: integration test
ae2483a chore: point to temp collab rev
80c5e9d chore: bump collab rev
cb288c6 chore: merge remote-tracking branch 'upstream/main' into insert-field-left-right
9962ea9 chore: fix tauri build
238ff8e chore: fix the tauri build, for real this time

📊 Changes

26 files changed (+478 additions, -256 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database/database_cell_test.dart (+84 -84)
📝 frontend/appflowy_flutter/integration_test/database/database_field_test.dart (+25 -2)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+14 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_editor_bloc.dart (+27 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/type_option_service.dart (+10 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/grid_header_bloc.dart (+33 -17)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart (+30 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart (+47 -12)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart (+41 -51)
📝 frontend/appflowy_tauri/src-tauri/Cargo.lock (+9 -9)
📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+8 -12)
📝 frontend/appflowy_tauri/src/appflowy_app/components/database/application/field/field_service.ts (+2 -2)
📝 frontend/appflowy_tauri/src/appflowy_app/stores/effects/database/field/type_option/type_option_bd_svc.ts (+2 -2)
➕ frontend/resources/flowy_icons/16x/arrow.svg (+3 -0)
📝 frontend/rust-lib/Cargo.lock (+9 -9)
📝 frontend/rust-lib/Cargo.toml (+9 -9)
📝 frontend/rust-lib/event-integration/src/database_event.rs (+2 -2)
📝 frontend/rust-lib/flowy-database2/src/entities/field_entities.rs (+70 -5)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+8 -5)
📝 frontend/rust-lib/flowy-database2/src/event_map.rs (+4 -3)

...and 6 more files

📄 Description

requires https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/124

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/45c9f1cf-ca6b-4b53-8d25-887dde165901

Also fixes a bug where the newly-created field's editing popup doesn't line up with it correctly.

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4022 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/27/2023 **Status:** ✅ Merged **Merged:** 11/28/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `insert-field-left-right` --- ### 📝 Commits (10+) - [`899e83a`](https://github.com/AppFlowy-IO/AppFlowy/commit/899e83adcc60aa4b954d0cd948565353e8e2eca1) feat: allow inserting fields before or after a certain field - [`abe8f94`](https://github.com/AppFlowy-IO/AppFlowy/commit/abe8f94687e437e32e49b5fd5e81449b50a4e851) fix: tauri build - [`b6d3fd9`](https://github.com/AppFlowy-IO/AppFlowy/commit/b6d3fd964f9a028fdfeff9ba5601680f5c066cd5) chore: implement frontend - [`a945ff6`](https://github.com/AppFlowy-IO/AppFlowy/commit/a945ff67506337ba93ab455992bbbdcd1a0f247d) test: rust-lib tests - [`778dc0a`](https://github.com/AppFlowy-IO/AppFlowy/commit/778dc0a797cc74b82a30668cb29836d14efea5b0) test: integration test - [`ae2483a`](https://github.com/AppFlowy-IO/AppFlowy/commit/ae2483acbd601e1e3c895178b171815759547e08) chore: point to temp collab rev - [`80c5e9d`](https://github.com/AppFlowy-IO/AppFlowy/commit/80c5e9d4c111806b4335000eb0fa7ce5b098501a) chore: bump collab rev - [`cb288c6`](https://github.com/AppFlowy-IO/AppFlowy/commit/cb288c62c603520002c1c437a8f35da4e8d03bd6) chore: merge remote-tracking branch 'upstream/main' into insert-field-left-right - [`9962ea9`](https://github.com/AppFlowy-IO/AppFlowy/commit/9962ea942677692be63f6277695fe52ecdac3dc1) chore: fix tauri build - [`238ff8e`](https://github.com/AppFlowy-IO/AppFlowy/commit/238ff8e6159ac8315f1115083f2825eddc892f61) chore: fix the tauri build, for real this time ### 📊 Changes **26 files changed** (+478 additions, -256 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database/database_cell_test.dart` (+84 -84) 📝 `frontend/appflowy_flutter/integration_test/database/database_field_test.dart` (+25 -2) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+14 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_editor_bloc.dart` (+27 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/type_option_service.dart` (+10 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/grid_header_bloc.dart` (+33 -17) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart` (+30 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart` (+47 -12) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart` (+41 -51) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.lock` (+9 -9) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+8 -12) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/database/application/field/field_service.ts` (+2 -2) 📝 `frontend/appflowy_tauri/src/appflowy_app/stores/effects/database/field/type_option/type_option_bd_svc.ts` (+2 -2) ➕ `frontend/resources/flowy_icons/16x/arrow.svg` (+3 -0) 📝 `frontend/rust-lib/Cargo.lock` (+9 -9) 📝 `frontend/rust-lib/Cargo.toml` (+9 -9) 📝 `frontend/rust-lib/event-integration/src/database_event.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/src/entities/field_entities.rs` (+70 -5) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+8 -5) 📝 `frontend/rust-lib/flowy-database2/src/event_map.rs` (+4 -3) _...and 6 more files_ </details> ### 📄 Description requires https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/124 https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/45c9f1cf-ca6b-4b53-8d25-887dde165901 Also fixes a bug where the newly-created field's editing popup doesn't line up with it correctly. ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>