[PR #4026] [MERGED] chore: some mobile grid issues #6008

Closed
opened 2026-03-23 22:21:18 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4026
Author: @richardshiue
Created: 11/27/2023
Status: Merged
Merged: 11/28/2023
Merged by: @LucasXu0

Base: mainHead: grid-review-fix


📝 Commits (2)

  • 9198e83 chore: some mobile grid issues
  • 0a16941 fix: grid right padding

📊 Changes

7 files changed (+80 additions, -74 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/layout/sizes.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/mobile_grid_page.dart (+9 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/footer/grid_footer.dart (+4 -9)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart (+36 -24)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/mobile_field_cell.dart (+24 -36)
📝 frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/tab_bar_view.dart (+2 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/scrolling/styled_scroll_bar.dart (+2 -2)

📄 Description

  • the border height of the the new property field is smaller than others. now it's lined up correctly
  • use click gesture instead of long pressing to rename field. now fixed. long press to reorder
  • small adjustments to icon color, text color, and padding throughout
Screenshot 2023-11-28 at 12 00 14 AM

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4026 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/27/2023 **Status:** ✅ Merged **Merged:** 11/28/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `grid-review-fix` --- ### 📝 Commits (2) - [`9198e83`](https://github.com/AppFlowy-IO/AppFlowy/commit/9198e831e19c4e135c108de5eeca4a6ca4b91507) chore: some mobile grid issues - [`0a16941`](https://github.com/AppFlowy-IO/AppFlowy/commit/0a169416f362bc1c683748d41a8f3a232948c729) fix: grid right padding ### 📊 Changes **7 files changed** (+80 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/layout/sizes.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/mobile_grid_page.dart` (+9 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/footer/grid_footer.dart` (+4 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart` (+36 -24) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/mobile_field_cell.dart` (+24 -36) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/tab_bar_view.dart` (+2 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/scrolling/styled_scroll_bar.dart` (+2 -2) </details> ### 📄 Description - the border height of the the new property field is smaller than others. now it's lined up correctly - use click gesture instead of long pressing to rename field. now fixed. long press to reorder - small adjustments to icon color, text color, and padding throughout <img width="458" alt="Screenshot 2023-11-28 at 12 00 14 AM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/1cd21e66-285c-4f35-bc20-92264eaca358"> ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:18 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6008
No description provided.