[PR #4039] [MERGED] feat: support select / multi select option #6016

Closed
opened 2026-03-23 22:21:20 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4039
Author: @LucasXu0
Created: 11/28/2023
Status: Merged
Merged: 11/29/2023
Merged by: @LucasXu0

Base: mainHead: editing_properties


📝 Commits (5)

  • c77ce0a feat: implement select option cell
  • e72f22c feat: support adding new select option
  • 46bacd1 feat: support selecting / deselecting option
  • 8799211 feat: clear search field after adding new property
  • 64bbba9 feat: support updating option name

📊 Changes

9 files changed (+778 additions, -26 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+2 -0)
frontend/appflowy_flutter/lib/mobile/presentation/database/field/edit_select_field.dart (+49 -0)
frontend/appflowy_flutter/lib/plugins/base/drag_handler.dart (+20 -0)
frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/mobile_select_option_editor.dart (+638 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_cell.dart (+50 -21)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart (+5 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart (+7 -4)
frontend/resources/flowy_icons/16x/m_checkbox_checked.svg (+4 -0)
frontend/resources/flowy_icons/16x/m_checkbox_uncheck.svg (+3 -0)

📄 Description

Feature Preview

How to integrate

showMobileBottomSheet(
  context: context,
  shape: const RoundedRectangleBorder(
    borderRadius: BorderRadius.vertical(
      top: Corners.s12Radius,
    ),
  ),
  builder: (context) {
    return MobileSelectOptionEditor(
      cellController: cellController,
    );
  },
);

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/d66e5a61-0302-4ac2-9494-61656ed68868


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4039 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/28/2023 **Status:** ✅ Merged **Merged:** 11/29/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `editing_properties` --- ### 📝 Commits (5) - [`c77ce0a`](https://github.com/AppFlowy-IO/AppFlowy/commit/c77ce0a4c0afb925108e9ddc33da9fd088de54d9) feat: implement select option cell - [`e72f22c`](https://github.com/AppFlowy-IO/AppFlowy/commit/e72f22c72e0d3cca5688a24414281b5e7b95c5b0) feat: support adding new select option - [`46bacd1`](https://github.com/AppFlowy-IO/AppFlowy/commit/46bacd136cbb1ff50dc2403680a283c49b7e55f5) feat: support selecting / deselecting option - [`8799211`](https://github.com/AppFlowy-IO/AppFlowy/commit/8799211b7d95149ecf100bee76a0dd6a2d458f14) feat: clear search field after adding new property - [`64bbba9`](https://github.com/AppFlowy-IO/AppFlowy/commit/64bbba9abb0cec5a2fd9ed88306a8fa9abb43588) feat: support updating option name ### 📊 Changes **9 files changed** (+778 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+2 -0) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/database/field/edit_select_field.dart` (+49 -0) ➕ `frontend/appflowy_flutter/lib/plugins/base/drag_handler.dart` (+20 -0) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/mobile_select_option_editor.dart` (+638 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_cell.dart` (+50 -21) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart` (+5 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart` (+7 -4) ➕ `frontend/resources/flowy_icons/16x/m_checkbox_checked.svg` (+4 -0) ➕ `frontend/resources/flowy_icons/16x/m_checkbox_uncheck.svg` (+3 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview **How to integrate** ```dart showMobileBottomSheet( context: context, shape: const RoundedRectangleBorder( borderRadius: BorderRadius.vertical( top: Corners.s12Radius, ), ), builder: (context) { return MobileSelectOptionEditor( cellController: cellController, ); }, ); ``` https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/d66e5a61-0302-4ac2-9494-61656ed68868 <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:20 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6016
No description provided.