[PR #4050] [MERGED] feat: hide tabbar when pushing to view page #6024

Closed
opened 2026-03-23 22:21:22 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4050
Author: @LucasXu0
Created: 11/30/2023
Status: Merged
Merged: 11/30/2023
Merged by: @LucasXu0

Base: mainHead: hide_tabbar_when_pushing


📝 Commits (2)

  • d8e07b9 feat: hide tabbar when pushing to view page
  • 921800e Merge branch 'main' into hide_tabbar_when_pushing

📊 Changes

8 files changed (+92 additions, -89 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart (+9 -12)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+25 -13)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/edit_username_bottom_sheet.dart (+44 -52)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/personal_info_setting_group.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_paginated_bottom_sheet.dart (+6 -9)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_cell.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart (+4 -0)

📄 Description

Feature Preview

Screenshot 2023-11-30 at 13 23 22 Screenshot 2023-11-30 at 13 23 33 Screenshot 2023-11-30 at 13 23 38

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4050 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/30/2023 **Status:** ✅ Merged **Merged:** 11/30/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `hide_tabbar_when_pushing` --- ### 📝 Commits (2) - [`d8e07b9`](https://github.com/AppFlowy-IO/AppFlowy/commit/d8e07b9a1cf01720ed5f24591c0d7043637c3503) feat: hide tabbar when pushing to view page - [`921800e`](https://github.com/AppFlowy-IO/AppFlowy/commit/921800e8ef64b9058fb1ab37c0c466897cc8eb9d) Merge branch 'main' into hide_tabbar_when_pushing ### 📊 Changes **8 files changed** (+92 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart` (+9 -12) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+25 -13) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/edit_username_bottom_sheet.dart` (+44 -52) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/personal_info_setting_group.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_paginated_bottom_sheet.dart` (+6 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/select_option_cell/select_option_cell.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart` (+4 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <img width="543" alt="Screenshot 2023-11-30 at 13 23 22" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ef0da18b-975e-45c8-8de9-3d99e616386e"> <img width="543" alt="Screenshot 2023-11-30 at 13 23 33" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/184b1bfd-7409-406e-a68a-a03c11e29fff"> <img width="543" alt="Screenshot 2023-11-30 at 13 23 38" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/d64cc9ba-0ae2-4eac-b1bd-1ed3096c7d1c"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:22 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6024
No description provided.