[PR #4055] [MERGED] fix: editor page issues #6027

Closed
opened 2026-03-23 22:21:23 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4055
Author: @LucasXu0
Created: 11/30/2023
Status: Merged
Merged: 12/1/2023
Merged by: @LucasXu0

Base: mainHead: fix_document_issues


📝 Commits (10+)

  • 36b61f6 fix: disable editor in card detail page
  • d97217c fix: mobile toolbar disappears after editing link
  • 6e60cd7 fix: favorite icon shows incorrectly
  • 1838f9f fix: inkWell when pressing on the Trash is different from the rest of our list tiles in the app
  • ca686ad fix: recent view didn't update after deleting view
  • 8a0f0ec fix: trash button too small
  • 310cbfd Merge branch 'main' into fix_document_issues
  • e2c8793 feat: use new bottom sheet style in cover plugin
  • f4446ea feat: use new bottom sheet style in add new page
  • 0c54b20 feat: use new bottom sheet style in view page option

📊 Changes

40 files changed (+613 additions, -330 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/application/mobile_router.dart (+4 -11)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart (+29 -35)
frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_item.dart (+118 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_item_header.dart (+16 -15)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart (+0 -27)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/default_mobile_action_pane.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+77 -127)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart (+1 -8)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_folders.dart (+0 -9)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart (+15 -22)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_trash_page.dart (+6 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/personal_folder/mobile_home_personal_folder.dart (+11 -7)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/recent_folder/mobile_home_recent_views.dart (+30 -36)
📝 frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/theme_setting.dart (+6 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/personal_info_setting_group.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_paginated_bottom_sheet.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart (+1 -1)

...and 20 more files

📄 Description

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4055 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/30/2023 **Status:** ✅ Merged **Merged:** 12/1/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_document_issues` --- ### 📝 Commits (10+) - [`36b61f6`](https://github.com/AppFlowy-IO/AppFlowy/commit/36b61f635c704a149d7dd9c70ea980e488c99e96) fix: disable editor in card detail page - [`d97217c`](https://github.com/AppFlowy-IO/AppFlowy/commit/d97217ca1d84b0763b45eb0e8455223dc427281a) fix: mobile toolbar disappears after editing link - [`6e60cd7`](https://github.com/AppFlowy-IO/AppFlowy/commit/6e60cd7ac579d3da6d4c295219334350220a1cad) fix: favorite icon shows incorrectly - [`1838f9f`](https://github.com/AppFlowy-IO/AppFlowy/commit/1838f9f448d1ada5700a5b5eed29548861520b90) fix: inkWell when pressing on the Trash is different from the rest of our list tiles in the app - [`ca686ad`](https://github.com/AppFlowy-IO/AppFlowy/commit/ca686ad29c00bc9b39e30d62c71a21b993e6d06c) fix: recent view didn't update after deleting view - [`8a0f0ec`](https://github.com/AppFlowy-IO/AppFlowy/commit/8a0f0ecaaae869a53139f2cb82f9d49dffc1d151) fix: trash button too small - [`310cbfd`](https://github.com/AppFlowy-IO/AppFlowy/commit/310cbfdc4ac91aca66cb0aee475648528cd9491f) Merge branch 'main' into fix_document_issues - [`e2c8793`](https://github.com/AppFlowy-IO/AppFlowy/commit/e2c87934f630d7e3a8f4dbc9673bb4cae6ea4c9f) feat: use new bottom sheet style in cover plugin - [`f4446ea`](https://github.com/AppFlowy-IO/AppFlowy/commit/f4446eaf64bb5afd223d11092b95748a12dc5d72) feat: use new bottom sheet style in add new page - [`0c54b20`](https://github.com/AppFlowy-IO/AppFlowy/commit/0c54b20231220fdb212cc7d635224f61d2164ed2) feat: use new bottom sheet style in view page option ### 📊 Changes **40 files changed** (+613 additions, -330 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/application/mobile_router.dart` (+4 -11) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart` (+29 -35) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_item.dart` (+118 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_item_header.dart` (+16 -15) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart` (+0 -27) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/default_mobile_action_pane.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+77 -127) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart` (+1 -8) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_folders.dart` (+0 -9) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart` (+15 -22) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_trash_page.dart` (+6 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/personal_folder/mobile_home_personal_folder.dart` (+11 -7) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/recent_folder/mobile_home_recent_views.dart` (+30 -36) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/theme_setting.dart` (+6 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/personal_info_setting_group.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_paginated_bottom_sheet.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart` (+1 -1) _...and 20 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:23 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6027
No description provided.