[PR #4059] [MERGED] fix: mobile bugs fix #6031

New issue

Closed

opened 2026-03-23 22:21:24 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4059
Author: @hyj1204
Created: 11/30/2023
Status: ✅ Merged
Merged: 12/2/2023
Merged by: @LucasXu0

Base: main ← Head: fix/mobile_bugs

📝 Commits (9)

69f3735 fix: add missing tap gesture
590106d fix: unify bottom sheet shape and padding
cbeba09 fix: fail to pop the detail page when add new card
1356ca7 fix: show card title placeholder when it is empty
9e0f2c4 refactor: ThirdPartySignInButtons
765ee37 chore: add resizeToAvoidBottomInset in showFlowyMobileBottomSheet
ca3d95f chore: refactor code
c9a4f2f chore: merge branch 'main' into fix/mobile_bugs
8e6163e Merge branch 'main' into fix/mobile_bugs

📊 Changes

5 files changed (+162 additions, -39 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_content/card_cells/text.dart (+24 -20)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_content/mobile_card_content.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/widgets/show_flowy_mobile_bottom_sheet.dart (+33 -11)
📝 frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/third_party_sign_in_buttons.dart (+94 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart (+6 -4)

📄 Description

Feature Preview

Fix 3rd party sign in buttons are not clickable.
Unify showFlowyMobileBottomSheet and showMobileBottomSheet.
When card title is empty, show placeholder title("Untitled").
Fix fail to pop the detail page when add new card
Add some colors to fix the dark mode better

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4059 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 11/30/2023 **Status:** ✅ Merged **Merged:** 12/2/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/mobile_bugs` --- ### 📝 Commits (9) - [`69f3735`](https://github.com/AppFlowy-IO/AppFlowy/commit/69f37354ad9830bfa3e579c1656e2501ec76eed7) fix: add missing tap gesture - [`590106d`](https://github.com/AppFlowy-IO/AppFlowy/commit/590106d48354c655e93f8f66f974f0ae7acd5552) fix: unify bottom sheet shape and padding - [`cbeba09`](https://github.com/AppFlowy-IO/AppFlowy/commit/cbeba09d50fead5360244bfb5d7ee27eb2099ded) fix: fail to pop the detail page when add new card - [`1356ca7`](https://github.com/AppFlowy-IO/AppFlowy/commit/1356ca7c81bda6e042c719a5041cb05a2be6684c) fix: show card title placeholder when it is empty - [`9e0f2c4`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e0f2c47f24283e3f9357b1eeabc4b04682b2a97) refactor: ThirdPartySignInButtons - [`765ee37`](https://github.com/AppFlowy-IO/AppFlowy/commit/765ee3730547faba1c2c2608f81a740a7cf2f727) chore: add resizeToAvoidBottomInset in showFlowyMobileBottomSheet - [`ca3d95f`](https://github.com/AppFlowy-IO/AppFlowy/commit/ca3d95fdb0379942ef3066c1e9814775a3146b55) chore: refactor code - [`c9a4f2f`](https://github.com/AppFlowy-IO/AppFlowy/commit/c9a4f2fd0ca5780e4ed1f04426bcc66ec011621b) chore: merge branch 'main' into fix/mobile_bugs - [`8e6163e`](https://github.com/AppFlowy-IO/AppFlowy/commit/8e6163e3c0409a1cf58d8383fdda35df4fcc6b23) Merge branch 'main' into fix/mobile_bugs ### 📊 Changes **5 files changed** (+162 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_content/card_cells/text.dart` (+24 -20) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_content/mobile_card_content.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/widgets/show_flowy_mobile_bottom_sheet.dart` (+33 -11) 📝 `frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/third_party_sign_in_buttons.dart` (+94 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart` (+6 -4) </details> ### 📄 Description   ### Feature Preview - Fix 3rd party sign in buttons are not clickable. - Unify showFlowyMobileBottomSheet and showMobileBottomSheet. - When card title is empty, show placeholder title("Untitled"). <img src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/28fe3b03-bdc3-4442-81a8-42c71f6a680a" width="300"> - Fix fail to pop the detail page when add new card - Add some colors to fix the dark mode better  ---  #### PR Checklist - [X] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [X] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>