[PR #4075] [MERGED] fix: launch review issues #6044

New issue

Closed

opened 2026-03-23 22:21:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4075
Author: @richardshiue
Created: 12/3/2023
Status: ✅ Merged
Merged: 12/4/2023
Merged by: @richardshiue

Base: main ← Head: launch-review-fixes

📝 Commits (10+)

bce2789 chore: add a tooltip for fields in row detail page
721144a fix: grouping by field makes cell contents disappear
320b32c chore: code cleanup
8eac3a6 chore: env var values in launch.json should be string
4088756 fix: group orders not being saved
0d947a0 test: fix test
c586be8 chore: more code cleanup
2af36c0 fix: field settings not found
e3f5fe1 chore: ellide cell text
9b8c0e0 fix: alignment issues in row detail page

📊 Changes

16 files changed (+145 additions, -213 deletions)

View changed files

📝 frontend/.vscode/launch.json (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_service.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_controller.dart (+7 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+6 -8)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/mobile_row.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/row.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/date_card_cell.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/number_cell/number_cell.dart (+19 -21)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/text_cell/text_cell.dart (+47 -54)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/url_cell/url_cell.dart (+31 -88)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart (+16 -6)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_type_option.rs (+2 -13)
📝 frontend/rust-lib/flowy-database2/src/services/group/configuration.rs (+4 -11)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/select_option_controller/single_select_controller.rs (+1 -4)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/test.rs (+1 -1)

📄 Description

about the group order fix, we cannot split right and discard all of the items in front because an old group might still in be in it.

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4075 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/3/2023 **Status:** ✅ Merged **Merged:** 12/4/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `launch-review-fixes` --- ### 📝 Commits (10+) - [`bce2789`](https://github.com/AppFlowy-IO/AppFlowy/commit/bce2789b79d1f40e698eefb28f9f6edc920fa4fc) chore: add a tooltip for fields in row detail page - [`721144a`](https://github.com/AppFlowy-IO/AppFlowy/commit/721144a01f635f808e9fe6e3063543c2a2e5cdd3) fix: grouping by field makes cell contents disappear - [`320b32c`](https://github.com/AppFlowy-IO/AppFlowy/commit/320b32c7813a371cf5ad60f6185a3a22a4def490) chore: code cleanup - [`8eac3a6`](https://github.com/AppFlowy-IO/AppFlowy/commit/8eac3a6300918a81bbc9fc8f1482354985cf9d2e) chore: env var values in launch.json should be string - [`4088756`](https://github.com/AppFlowy-IO/AppFlowy/commit/4088756ad97b03d503d6b6696769d2dc64e598c2) fix: group orders not being saved - [`0d947a0`](https://github.com/AppFlowy-IO/AppFlowy/commit/0d947a0f170db3f793c97ce9f417a4b02bec4585) test: fix test - [`c586be8`](https://github.com/AppFlowy-IO/AppFlowy/commit/c586be839294ee0257b4c147a678e031d7dabc26) chore: more code cleanup - [`2af36c0`](https://github.com/AppFlowy-IO/AppFlowy/commit/2af36c0859068619d87289eed9b36b1d2266f76b) fix: field settings not found - [`e3f5fe1`](https://github.com/AppFlowy-IO/AppFlowy/commit/e3f5fe18424d916cb14995dae83130915876dd27) chore: ellide cell text - [`9b8c0e0`](https://github.com/AppFlowy-IO/AppFlowy/commit/9b8c0e0328a288b00bc1d9704b8270cd18cffa16) fix: alignment issues in row detail page ### 📊 Changes **16 files changed** (+145 additions, -213 deletions) <details> <summary>View changed files</summary> 📝 `frontend/.vscode/launch.json` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_service.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_controller.dart` (+7 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+6 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/mobile_row.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/row.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/date_card_cell.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cell.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/number_cell/number_cell.dart` (+19 -21) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/text_cell/text_cell.dart` (+47 -54) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/url_cell/url_cell.dart` (+31 -88) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart` (+16 -6) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_type_option.rs` (+2 -13) 📝 `frontend/rust-lib/flowy-database2/src/services/group/configuration.rs` (+4 -11) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/select_option_controller/single_select_controller.rs` (+1 -4) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/test.rs` (+1 -1) </details> ### 📄 Description about the group order fix, we cannot split right and discard all of the items in front because an old group might still in be in it. ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>