[PR #4080] [MERGED] fix: persist group order on reopenning AppFlowy #6048

Closed
opened 2026-03-23 22:21:28 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4080
Author: @zoli
Created: 12/4/2023
Status: Merged
Merged: 12/20/2023
Merged by: @appflowy

Base: mainHead: fix/persist-group-order


📝 Commits (4)

  • e88f84f fix: persist group order on reopenning AppFlowy
  • 41c9352 style: merge main
  • c37e037 refactor: enhance the merge_group function
  • a30ea4a refactor: use extend instead of for loop

📊 Changes

2 files changed (+82 additions, -6 deletions)

View changed files

📝 frontend/appflowy_flutter/linux/flutter/dart_ffi/binding.h (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/group/configuration.rs (+81 -5)

📄 Description

Currently if you change groups order, on restarting AppFlowy they will go back to what they were before.
This was because merge_groups function was not respecting the group orders which were saved before as group settings.

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4080 **Author:** [@zoli](https://github.com/zoli) **Created:** 12/4/2023 **Status:** ✅ Merged **Merged:** 12/20/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/persist-group-order` --- ### 📝 Commits (4) - [`e88f84f`](https://github.com/AppFlowy-IO/AppFlowy/commit/e88f84f1ee3af21ef23aad69e046c94719521d77) fix: persist group order on reopenning AppFlowy - [`41c9352`](https://github.com/AppFlowy-IO/AppFlowy/commit/41c9352a66ad23999ea74b13230eec96e7db57e5) style: merge main - [`c37e037`](https://github.com/AppFlowy-IO/AppFlowy/commit/c37e037ef524309999f84ab780db7cc898764c61) refactor: enhance the merge_group function - [`a30ea4a`](https://github.com/AppFlowy-IO/AppFlowy/commit/a30ea4a3453de7bbaa19bc07b59bc5172d9c11ea) refactor: use extend instead of for loop ### 📊 Changes **2 files changed** (+82 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/linux/flutter/dart_ffi/binding.h` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/group/configuration.rs` (+81 -5) </details> ### 📄 Description Currently if you change groups order, on restarting AppFlowy they will go back to what they were before. This was because merge_groups function was not respecting the group orders which were saved before as group settings. ### Feature Preview --- #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:28 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6048
No description provided.