[PR #4122] [MERGED] fix: notes disappears #6074

Closed
opened 2026-03-23 22:21:35 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4122
Author: @Xazin
Created: 12/9/2023
Status: Merged
Merged: 12/10/2023
Merged by: @Xazin

Base: mainHead: fix/notes-disappears


📝 Commits (10+)

  • d9ea10c chore: remove redundant todos
  • c7022fd feat: show page icon in reference menus
  • d0b4f6f fix: show page icon for page reference
  • 8c52d41 fix: add hover effect to document more button
  • 8a0ab7c fix: add tooltip to notes hint
  • 46a8453 fix: add hover and tooltip to New card button
  • 6eb69bb fix: missing localization + cleaning
  • 46be1eb fix: tooltip on add new stuck
  • 281b2c9 chore: remove unused const
  • 97f1b8d fix: notes icon in card disappears

📊 Changes

25 files changed (+193 additions, -263 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_text.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/number_format_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+30 -20)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart (+7 -9)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/text_card_cell.dart (+7 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/container/card_container.dart (+11 -9)
📝 frontend/appflowy_flutter/lib/plugins/document/document.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+0 -1)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/color_extension.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/upload_image_menu.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart (+21 -14)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/service/openai_client.dart (+0 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/more/more_button.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart (+10 -1)
frontend/appflowy_flutter/lib/util/either_extension.dart (+0 -6)
📝 frontend/appflowy_flutter/lib/util/theme_mode_extension.dart (+6 -12)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart (+50 -112)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart (+7 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+1 -3)

...and 5 more files

📄 Description

Closes: #4008
Closes: #3908

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4122 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 12/9/2023 **Status:** ✅ Merged **Merged:** 12/10/2023 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/notes-disappears` --- ### 📝 Commits (10+) - [`d9ea10c`](https://github.com/AppFlowy-IO/AppFlowy/commit/d9ea10c81308fb4f29d3f80748049a4320f928ea) chore: remove redundant todos - [`c7022fd`](https://github.com/AppFlowy-IO/AppFlowy/commit/c7022fd747326a7b5614337db85910cb371073d8) feat: show page icon in reference menus - [`d0b4f6f`](https://github.com/AppFlowy-IO/AppFlowy/commit/d0b4f6f205b5d606de9dc86ff771b803b5af927e) fix: show page icon for page reference - [`8c52d41`](https://github.com/AppFlowy-IO/AppFlowy/commit/8c52d414226e197cc989ae22d560b9ecc75d16e3) fix: add hover effect to document more button - [`8a0ab7c`](https://github.com/AppFlowy-IO/AppFlowy/commit/8a0ab7cf1de3e9da70e7829f7ea389f50a58722a) fix: add tooltip to notes hint - [`46a8453`](https://github.com/AppFlowy-IO/AppFlowy/commit/46a845302ac2464f59692f90c1ec2abc3b851894) fix: add hover and tooltip to New card button - [`6eb69bb`](https://github.com/AppFlowy-IO/AppFlowy/commit/6eb69bb21f2dbba2244151d732e620864d1f9780) fix: missing localization + cleaning - [`46be1eb`](https://github.com/AppFlowy-IO/AppFlowy/commit/46be1eb8e556d56bda0cb5b306b78a814268ab00) fix: tooltip on add new stuck - [`281b2c9`](https://github.com/AppFlowy-IO/AppFlowy/commit/281b2c966603cb45b898ad2701fbcba9aa305c07) chore: remove unused const - [`97f1b8d`](https://github.com/AppFlowy-IO/AppFlowy/commit/97f1b8dd68fd8a0851269936148d72c5c490765a) fix: notes icon in card disappears ### 📊 Changes **25 files changed** (+193 additions, -263 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/base/emoji/emoji_text.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/number_format_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+30 -20) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/grid_page.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart` (+7 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/text_card_cell.dart` (+7 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/container/card_container.dart` (+11 -9) 📝 `frontend/appflowy_flutter/lib/plugins/document/document.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+0 -1) ➖ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/color_extension.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/upload_image_menu.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart` (+21 -14) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/service/openai_client.dart` (+0 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/more/more_button.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart` (+10 -1) ➖ `frontend/appflowy_flutter/lib/util/either_extension.dart` (+0 -6) 📝 `frontend/appflowy_flutter/lib/util/theme_mode_extension.dart` (+6 -12) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart` (+50 -112) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart` (+7 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+1 -3) _...and 5 more files_ </details> ### 📄 Description Closes: #4008 Closes: #3908 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:35 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6074
No description provided.