[PR #4126] [MERGED] fix: database memory leaks #6078

New issue

Closed

opened 2026-03-23 22:21:37 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4126
Author: @LucasXu0
Created: 12/11/2023
Status: ✅ Merged
Merged: 12/11/2023
Merged by: @LucasXu0

Base: main ← Head: fix_memory_leak3

📝 Commits (2)

fa510b7 fix: database memory leaks
5737bc8 Merge branch 'main' into fix_memory_leak3

📊 Changes

25 files changed (+76 additions, -83 deletions)

View changed files

📝 frontend/.vscode/launch.json (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/type_option_data_controller.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+9 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/toolbar/calendar_layout_setting.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/grid_header_bloc.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/select_option/select_option.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/create_filter_list.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_list.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart (+19 -12)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/date.dart (+3 -6)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/number.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option_editor.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/action.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/sort/create_sort_list.dart (+0 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/desktop/tab_bar_header.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/tab_bar_view.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_layout_selector.dart (+0 -2)

...and 5 more files

📄 Description

Feature Preview

TBD

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4126 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 12/11/2023 **Status:** ✅ Merged **Merged:** 12/11/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_memory_leak3` --- ### 📝 Commits (2) - [`fa510b7`](https://github.com/AppFlowy-IO/AppFlowy/commit/fa510b7e5abebe5a94a9526419435021ec5a2363) fix: database memory leaks - [`5737bc8`](https://github.com/AppFlowy-IO/AppFlowy/commit/5737bc800c69361e59fdb4cd8e17dd570fb744c1) Merge branch 'main' into fix_memory_leak3 ### 📊 Changes **25 files changed** (+76 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `frontend/.vscode/launch.json` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/type_option_data_controller.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+9 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/toolbar/calendar_layout_setting.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/grid_header_bloc.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/choicechip/select_option/select_option.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/filter/create_filter_list.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_type_list.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart` (+19 -12) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/date.dart` (+3 -6) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/number.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/type_option/select_option_editor.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/action.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/sort/create_sort_list.dart` (+0 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/desktop/tab_bar_header.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/tab_bar_view.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_editor.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_layout_selector.dart` (+0 -2) _...and 5 more files_ </details> ### 📄 Description   ### Feature Preview TBD  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>