[PR #4146] [MERGED] feat: borders on mobile grid #6091

Closed
opened 2026-03-23 22:21:40 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4146
Author: @richardshiue
Created: 12/14/2023
Status: Merged
Merged: 12/14/2023
Merged by: @richardshiue

Base: mainHead: feat/mobile-grid-improv


📝 Commits (2)

  • 512dd68 feat: mobile grid ui improvements
  • 6086919 chore: restore Podfile.lock

📊 Changes

13 files changed (+494 additions, -305 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/board/mobile_board_content.dart (+41 -24)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_page.dart (+38 -21)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/mobile_grid_page.dart (+56 -35)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/desktop_field_cell.dart (+0 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart (+37 -85)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/mobile_field_button.dart (+45 -10)
frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/mobile_grid_header.dart (+212 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/mobile_fab.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/mobile_row.dart (+10 -13)
📝 frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/mobile/mobile_tab_bar_header.dart (+37 -48)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/mobile_cell_container.dart (+12 -64)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart (+1 -1)

📄 Description

Screenshot 2023-12-14 at 10 17 14 PM

Also adjusted the fab to have a light border as well.

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4146 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/14/2023 **Status:** ✅ Merged **Merged:** 12/14/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/mobile-grid-improv` --- ### 📝 Commits (2) - [`512dd68`](https://github.com/AppFlowy-IO/AppFlowy/commit/512dd6896cdaf8daf67d0f7d9967eb0a2afa9699) feat: mobile grid ui improvements - [`6086919`](https://github.com/AppFlowy-IO/AppFlowy/commit/6086919e140ad6a0ce84b33b0b7698e81a97e961) chore: restore Podfile.lock ### 📊 Changes **13 files changed** (+494 additions, -305 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/board/mobile_board_content.dart` (+41 -24) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_page.dart` (+38 -21) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/mobile_grid_page.dart` (+56 -35) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/desktop_field_cell.dart` (+0 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/grid_header.dart` (+37 -85) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/mobile_field_button.dart` (+45 -10) ➕ `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/mobile_grid_header.dart` (+212 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/mobile_fab.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/mobile_row.dart` (+10 -13) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/mobile/mobile_tab_bar_header.dart` (+37 -48) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/mobile_cell_container.dart` (+12 -64) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_property.dart` (+1 -1) </details> ### 📄 Description <img width="484" alt="Screenshot 2023-12-14 at 10 17 14 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/5524b122-3d7c-41fb-befc-335544ea7966"> Also adjusted the fab to have a light border as well. ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:40 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6091
No description provided.