[PR #4148] [MERGED] refactor: some code organization and date picker ui improv #6094

New issue

Closed

opened 2026-03-23 22:21:41 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4148
Author: @richardshiue
Created: 12/15/2023
Status: ✅ Merged
Merged: 12/15/2023
Merged by: @richardshiue

Base: main ← Head: chore/mobile-db-tab-bar

📝 Commits (3)

67c7157 chore: use appflowy_editor's platform extensions
b3fa4b3 chore: organize code
84fe558 chore: improve mobile date picker

📊 Changes

32 files changed (+54 additions, -114 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/database/date_picker/mobile_date_picker_screen.dart (+19 -21)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/bottom_sheet_create_field.dart (+5 -4)
➖ frontend/appflowy_flutter/lib/mobile/presentation/database/field/edit_select_field.dart (+0 -49)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_create_field_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_edit_field_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_grid.dart (+0 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_option_editor.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_event_card.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/tab_bar_view.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_cell_builder.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_layout_selector.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_setting_action.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_settings_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_property_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+1 -1)

...and 12 more files

📄 Description

use the same PlatformExtension throughout codebase, from appflowy_editor.
rename some files here, move some files there
change background color of mobile date picker to secondary container to avoid ugliness during overscroll

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4148 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 12/15/2023 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `chore/mobile-db-tab-bar` --- ### 📝 Commits (3) - [`67c7157`](https://github.com/AppFlowy-IO/AppFlowy/commit/67c715731eda6106e8268dc93f10546e41c75d88) chore: use appflowy_editor's platform extensions - [`b3fa4b3`](https://github.com/AppFlowy-IO/AppFlowy/commit/b3fa4b335f1c6511ddf222e8f65697520823f427) chore: organize code - [`84fe558`](https://github.com/AppFlowy-IO/AppFlowy/commit/84fe558331bcb257cc4180647e9b0ae8b8aae223) chore: improve mobile date picker ### 📊 Changes **32 files changed** (+54 additions, -114 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/date_picker/mobile_date_picker_screen.dart` (+19 -21) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/bottom_sheet_create_field.dart` (+5 -4) ➖ `frontend/appflowy_flutter/lib/mobile/presentation/database/field/edit_select_field.dart` (+0 -49) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_create_field_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_edit_field_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_grid.dart` (+0 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_option_editor.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_event_card.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/tab_bar/tab_bar_view.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_cell_builder.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_layout_selector.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_setting_action.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/database_settings_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/setting/setting_property_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+1 -1) _...and 12 more files_ </details> ### 📄 Description - use the same PlatformExtension throughout codebase, from appflowy_editor. - rename some files here, move some files there - change background color of mobile date picker to secondary container to avoid ugliness during overscroll <img width="250" alt="Screenshot 2023-12-15 at 5 13 52 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/d6babf79-7053-43eb-9ea6-c4142d16c96f"> ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>