[PR #4150] [MERGED] feat: sync the icon & title #6097

Closed
opened 2026-03-23 22:21:42 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4150
Author: @LucasXu0
Created: 12/16/2023
Status: Merged
Merged: 12/20/2023
Merged by: @LucasXu0

Base: mainHead: sync_icon_and_title


📝 Commits (6)

  • 4106dd6 feat: sync the icon & title
  • 38e01c3 feat: diff the view data when refreshing
  • 528a489 Merge branch 'main' into sync_icon_and_title
  • f0198ca fix: unable to update folder
  • e2a8cae Merge branch 'main' into sync_icon_and_title
  • 2122514 test: refactor bloc tests

📊 Changes

24 files changed (+374 additions, -785 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/util/expectation.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/personal_folder/mobile_home_personal_folder.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart (+2 -6)
frontend/appflowy_flutter/lib/workspace/application/app/app_bloc.dart (+0 -286)
frontend/appflowy_flutter/lib/workspace/application/app/prelude.dart (+0 -1)
frontend/appflowy_flutter/lib/workspace/application/menu/menu_view_section_bloc.dart (+0 -109)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_bloc.dart (+135 -32)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/draggable_view_item.dart (+0 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+1 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart (+3 -1)
📝 frontend/appflowy_flutter/packages/appflowy_backend/lib/log.dart (+35 -15)
📝 frontend/appflowy_flutter/packages/appflowy_backend/pubspec.yaml (+1 -1)
📝 frontend/appflowy_flutter/pubspec.lock (+3 -3)
📝 frontend/appflowy_flutter/pubspec.yaml (+2 -0)
📝 frontend/appflowy_flutter/test/bloc_test/board_test/util.dart (+3 -3)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_util.dart (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/util.dart (+1 -1)
frontend/appflowy_flutter/test/bloc_test/home_test/app_bloc_test.dart (+0 -166)
frontend/appflowy_flutter/test/bloc_test/home_test/create_page_test.dart (+0 -63)
📝 frontend/appflowy_flutter/test/bloc_test/home_test/home_bloc_test.dart (+8 -8)

...and 4 more files

📄 Description

Feature Preview

Known issues: unable to sync the newly created page.

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ff5b2e10-fdcf-46c3-b85e-7593d357d429


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4150 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 12/16/2023 **Status:** ✅ Merged **Merged:** 12/20/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `sync_icon_and_title` --- ### 📝 Commits (6) - [`4106dd6`](https://github.com/AppFlowy-IO/AppFlowy/commit/4106dd622ea34c8b3cbcdc892fd82256173bcb36) feat: sync the icon & title - [`38e01c3`](https://github.com/AppFlowy-IO/AppFlowy/commit/38e01c3fdb6b91ad30a22473925215609e72dfd4) feat: diff the view data when refreshing - [`528a489`](https://github.com/AppFlowy-IO/AppFlowy/commit/528a4897ec6eebd5131b763fcd66c6fd7d7ba143) Merge branch 'main' into sync_icon_and_title - [`f0198ca`](https://github.com/AppFlowy-IO/AppFlowy/commit/f0198ca5bfc5f78b09e43b72d4500ca1b5521589) fix: unable to update folder - [`e2a8cae`](https://github.com/AppFlowy-IO/AppFlowy/commit/e2a8cae4f60e22f902294b82ea12344f7726bb1c) Merge branch 'main' into sync_icon_and_title - [`2122514`](https://github.com/AppFlowy-IO/AppFlowy/commit/21225147dd39317d10433e2e552517e36272c075) test: refactor bloc tests ### 📊 Changes **24 files changed** (+374 additions, -785 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/util/expectation.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/personal_folder/mobile_home_personal_folder.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart` (+2 -6) ➖ `frontend/appflowy_flutter/lib/workspace/application/app/app_bloc.dart` (+0 -286) ➖ `frontend/appflowy_flutter/lib/workspace/application/app/prelude.dart` (+0 -1) ➖ `frontend/appflowy_flutter/lib/workspace/application/menu/menu_view_section_bloc.dart` (+0 -109) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_bloc.dart` (+135 -32) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/draggable_view_item.dart` (+0 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+1 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart` (+3 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_backend/lib/log.dart` (+35 -15) 📝 `frontend/appflowy_flutter/packages/appflowy_backend/pubspec.yaml` (+1 -1) 📝 `frontend/appflowy_flutter/pubspec.lock` (+3 -3) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+2 -0) 📝 `frontend/appflowy_flutter/test/bloc_test/board_test/util.dart` (+3 -3) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_util.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/util.dart` (+1 -1) ➖ `frontend/appflowy_flutter/test/bloc_test/home_test/app_bloc_test.dart` (+0 -166) ➖ `frontend/appflowy_flutter/test/bloc_test/home_test/create_page_test.dart` (+0 -63) 📝 `frontend/appflowy_flutter/test/bloc_test/home_test/home_bloc_test.dart` (+8 -8) _...and 4 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview ~~Known issues: unable to sync the newly created page.~~ https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/ff5b2e10-fdcf-46c3-b85e-7593d357d429 <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:42 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6097
No description provided.