[PR #4170] [MERGED] feat: Add confirmation when deleting/restoring a page in the trash. #6104

New issue

Closed

opened 2026-03-23 22:21:43 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:21:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4170
Author: @AnsahMohammad
Created: 12/19/2023
Status: ✅ Merged
Merged: 12/19/2023
Merged by: @LucasXu0

Base: main ← Head: trash_prompt_4165

📝 Commits (6)

c27bf24 feat: added prompt before delete and restore
480786b feat: added prompts before delete all and restore all
04edfda chore: fixed indendation
17e28c9 refactor: changed the confirmation dialogue to use NavigatorAlertDialog
bf3b550 chore: replaced text with localisable string and removed message from confirmationDialog
f211cc4 refactor: Use alert directly from NavigatorAlertDialog

📊 Changes

1 file changed (+35 additions, -8 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/trash/trash_page.dart (+35 -8)

📄 Description

Feature Preview

Added prompt that asks for confirmation before "deleting" or "restoring" the files from the trash

This PR closes #4165

In this PR I have implemented a Prompt that asks for confirmation before deleting or restoring files from the trash usin the NavigatorAlertDialog.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4170 **Author:** [@AnsahMohammad](https://github.com/AnsahMohammad) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `trash_prompt_4165` --- ### 📝 Commits (6) - [`c27bf24`](https://github.com/AppFlowy-IO/AppFlowy/commit/c27bf241ed80aeda2fe0895997a824b4e8caa0c9) feat: added prompt before delete and restore - [`480786b`](https://github.com/AppFlowy-IO/AppFlowy/commit/480786bf7ac22a458f1cd6d5dafe023ab81baee2) feat: added prompts before delete all and restore all - [`04edfda`](https://github.com/AppFlowy-IO/AppFlowy/commit/04edfdab49126ced8f1dcb14edcadb8abb3e18db) chore: fixed indendation - [`17e28c9`](https://github.com/AppFlowy-IO/AppFlowy/commit/17e28c9d58ed01fb344bc8bfceab3e48ccdd799d) refactor: changed the confirmation dialogue to use NavigatorAlertDialog - [`bf3b550`](https://github.com/AppFlowy-IO/AppFlowy/commit/bf3b55033deeca509f32783d8454acd597f62eaf) chore: replaced text with localisable string and removed message from confirmationDialog - [`f211cc4`](https://github.com/AppFlowy-IO/AppFlowy/commit/f211cc45831508016bbd53f79d7f8da7c1eb254d) refactor: Use alert directly from NavigatorAlertDialog ### 📊 Changes **1 file changed** (+35 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/trash/trash_page.dart` (+35 -8) </details> ### 📄 Description ### Feature Preview Added prompt that asks for confirmation before "deleting" or "restoring" the files from the trash This PR closes #4165 In this PR I have implemented a Prompt that asks for confirmation before deleting or restoring files from the trash usin the `NavigatorAlertDialog`. --- ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/85027826/fe1ceae1-2849-4b3d-86c3-75ee09845e56)  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>