[PR #4229] [MERGED] fix: notify all views of field type option changes #6142

Closed
opened 2026-03-23 22:21:54 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4229
Author: @richardshiue
Created: 12/28/2023
Status: Merged
Merged: 12/29/2023
Merged by: @appflowy

Base: mainHead: fix/kanban-new-card-wrong-column


📝 Commits (1)

  • 649fc1d fix: notify all views of field type option

📊 Changes

7 files changed (+40 additions, -53 deletions)

View changed files

📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+2 -12)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+28 -19)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+3 -6)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_operation.rs (+0 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/field_operation.rs (+3 -6)
📝 frontend/rust-lib/flowy-database2/tests/database/field_test/script.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs (+3 -8)

📄 Description

This is a hot-fix for a bug where if a new option is inserted in a grid, a relevant stack isn't being created in a linked kanban board.

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4229 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/28/2023 **Status:** ✅ Merged **Merged:** 12/29/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/kanban-new-card-wrong-column` --- ### 📝 Commits (1) - [`649fc1d`](https://github.com/AppFlowy-IO/AppFlowy/commit/649fc1d18f0ee603223f9be22bb24cf7810d66e9) fix: notify all views of field type option ### 📊 Changes **7 files changed** (+40 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+2 -12) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+28 -19) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+3 -6) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_operation.rs` (+0 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/field_operation.rs` (+3 -6) 📝 `frontend/rust-lib/flowy-database2/tests/database/field_test/script.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs` (+3 -8) </details> ### 📄 Description This is a hot-fix for a bug where if a new option is inserted in a grid, a relevant stack isn't being created in a linked kanban board. ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:21:54 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6142
No description provided.