[PR #4301] [MERGED] feat: improve reference menus #6184

New issue

Closed

opened 2026-03-23 22:22:05 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4301
Author: @Xazin
Created: 1/4/2024
Status: ✅ Merged
Merged: 1/8/2024
Merged by: @Xazin

Base: main ← Head: fix/align-reference-menus

📝 Commits (10+)

8226a20 feat: improve reference menus
14db556 fix: limit page results in reference menus
44c2fe7 fix: custom title for specific type refs
4b05284 fix: insert pages
1eeba9e fix: enable scrolling on item focus change
7f77a01 fix: enable shift+tab to navigate
2b1483e Merge branch 'main' into fix/align-reference-menus
155d42e fix: properly offset menu
2e70bb0 fix: review comments
d561427 fix: remove bottom padding on last group

📊 Changes

12 files changed (+356 additions, -382 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/document/document_inline_page_reference_test.dart (+4 -3)
📝 frontend/appflowy_flutter/integration_test/document/document_with_database_test.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart (+4 -13)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart (+52 -233)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/page_reference_commands.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/database/referenced_database_menu_item.dart (+8 -35)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart (+145 -57)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_menu.dart (+7 -4)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart (+123 -32)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart (+3 -1)
📝 frontend/resources/translations/en.json (+5 -1)

📄 Description

Relates: #4300 #4179 #4031 #3841

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/afeadfba-efa4-4590-9f5b-ce65f6a3e06a

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4301 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 1/4/2024 **Status:** ✅ Merged **Merged:** 1/8/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/align-reference-menus` --- ### 📝 Commits (10+) - [`8226a20`](https://github.com/AppFlowy-IO/AppFlowy/commit/8226a2042edc8d413099858b7ade1a0b21e7ecbb) feat: improve reference menus - [`14db556`](https://github.com/AppFlowy-IO/AppFlowy/commit/14db556f2080439e31b0c8035dc15cecb2022681) fix: limit page results in reference menus - [`44c2fe7`](https://github.com/AppFlowy-IO/AppFlowy/commit/44c2fe7d1224d46903f1c89b87b5ab704e9bde66) fix: custom title for specific type refs - [`4b05284`](https://github.com/AppFlowy-IO/AppFlowy/commit/4b0528496b2b976ca4b19a57512f506958843dad) fix: insert pages - [`1eeba9e`](https://github.com/AppFlowy-IO/AppFlowy/commit/1eeba9eb19ef0155c73c94bc1724c8a4da59bc3f) fix: enable scrolling on item focus change - [`7f77a01`](https://github.com/AppFlowy-IO/AppFlowy/commit/7f77a012503a12b207b127b5db5195c6903f8866) fix: enable shift+tab to navigate - [`2b1483e`](https://github.com/AppFlowy-IO/AppFlowy/commit/2b1483e49e1321f7ea11531009de0d2b937b6e2c) Merge branch 'main' into fix/align-reference-menus - [`155d42e`](https://github.com/AppFlowy-IO/AppFlowy/commit/155d42eaaa864780321f968c610f82cbb6e7bf22) fix: properly offset menu - [`2e70bb0`](https://github.com/AppFlowy-IO/AppFlowy/commit/2e70bb0a2ebc9378189b1a09ca0e4dfdd01587b5) fix: review comments - [`d561427`](https://github.com/AppFlowy-IO/AppFlowy/commit/d5614278cd3aa2467f62ec12c9499ecb3c5c4de3) fix: remove bottom padding on last group ### 📊 Changes **12 files changed** (+356 additions, -382 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/document/document_inline_page_reference_test.dart` (+4 -3) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_database_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/insert_page_command.dart` (+4 -13) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/link_to_page_widget.dart` (+52 -233) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/page_reference_commands.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/database/referenced_database_menu_item.dart` (+8 -35) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart` (+145 -57) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_menu.dart` (+7 -4) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart` (+123 -32) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart` (+3 -1) 📝 `frontend/resources/translations/en.json` (+5 -1) </details> ### 📄 Description Relates: #4300 #4179 #4031 #3841 ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/afeadfba-efa4-4590-9f5b-ce65f6a3e06a --- #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>