[PR #4317] [MERGED] fix: upload custom theme issue #6190

New issue

Closed

opened 2026-03-23 22:22:07 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4317
Author: @hyj1204
Created: 1/5/2024
Status: ✅ Merged
Merged: 1/10/2024
Merged by: @LucasXu0

Base: main ← Head: fix/theme_customization

📝 Commits (7)

051a3e0 fix: FlowyDynamicPlugin encode issue
0ecdc2f chore: improve the default theme color
9ff48fb fix: learn more button text invisiable
b15b86a fix: fix read the wrong theme mode file
3d898c0 fix: prevent current custom theme being deleted
3a2e325 chore: improve theme upload UI and error prompts
5df7b72 chore: delete unnecessary LocaleKeys

📊 Changes

12 files changed (+131 additions, -87 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/color_scheme.dart (+2 -1)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload.dart (+8 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_failure_widget.dart (+9 -7)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_learn_more_button.dart (+58 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_view.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/upload_new_theme_widget.dart (+5 -51)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart (+4 -4)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/plugins/bloc/dynamic_plugin_bloc.dart (+3 -2)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/plugins/bloc/dynamic_plugin_state.dart (+2 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/plugins/service/models/flowy_dynamic_plugin.dart (+33 -14)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/buttons/secondary_button.dart (+2 -2)
📝 frontend/resources/translations/en.json (+0 -1)

📄 Description

Feature Preview

Fix the path issue in encoding FlowyDynamicPlugin
Show a detailed message when an upload error occurs: The error messages are under the flowy_infra package which cannot access the LocaleKeys, so I didn't add the localization for them.
Show the ‘Delete’ button only if the custom theme is not the current theme.
Some improvement on upload theme UI

https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/e17a55dc-0ce8-4fb5-a085-be33f75f44d3

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4317 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 1/5/2024 **Status:** ✅ Merged **Merged:** 1/10/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/theme_customization` --- ### 📝 Commits (7) - [`051a3e0`](https://github.com/AppFlowy-IO/AppFlowy/commit/051a3e0e7062d0822ea8a6ac84388bf9853e63a4) fix: FlowyDynamicPlugin encode issue - [`0ecdc2f`](https://github.com/AppFlowy-IO/AppFlowy/commit/0ecdc2fbf15115ce434b2bf3b8a9b9003348039b) chore: improve the default theme color - [`9ff48fb`](https://github.com/AppFlowy-IO/AppFlowy/commit/9ff48fb080ffbb0fa91468b38a42ef5978b1cf18) fix: learn more button text invisiable - [`b15b86a`](https://github.com/AppFlowy-IO/AppFlowy/commit/b15b86ac0a500aa86515a38ac0d34e9c4ba0d4ae) fix: fix read the wrong theme mode file - [`3d898c0`](https://github.com/AppFlowy-IO/AppFlowy/commit/3d898c02142f3c0398badfce4a8c526712c74f89) fix: prevent current custom theme being deleted - [`3a2e325`](https://github.com/AppFlowy-IO/AppFlowy/commit/3a2e325ad2c955ac3915294b3f4cb3ae92277e12) chore: improve theme upload UI and error prompts - [`5df7b72`](https://github.com/AppFlowy-IO/AppFlowy/commit/5df7b725d809c7f653b98aaefbf32eece0efeb5a) chore: delete unnecessary LocaleKeys ### 📊 Changes **12 files changed** (+131 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance/color_scheme.dart` (+2 -1) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload.dart` (+8 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_failure_widget.dart` (+9 -7) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_learn_more_button.dart` (+58 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_view.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/upload_new_theme_widget.dart` (+5 -51) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart` (+4 -4) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/plugins/bloc/dynamic_plugin_bloc.dart` (+3 -2) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/plugins/bloc/dynamic_plugin_state.dart` (+2 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/plugins/service/models/flowy_dynamic_plugin.dart` (+33 -14) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/buttons/secondary_button.dart` (+2 -2) 📝 `frontend/resources/translations/en.json` (+0 -1) </details> ### 📄 Description   ### Feature Preview - Fix the path issue in encoding FlowyDynamicPlugin - Show a detailed message when an upload error occurs: The error messages are under the `flowy_infra` package which cannot access the `LocaleKeys`, so I didn't add the localization for them. - Show the ‘Delete’ button only if the custom theme is not the current theme. - Some improvement on upload theme UI https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/e17a55dc-0ce8-4fb5-a085-be33f75f44d3  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>