[PR #4426] [MERGED] Fix: Enable more text to be translated #6249

New issue

Closed

opened 2026-03-23 22:22:23 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4426
Author: @jpenna
Created: 1/19/2024
Status: ✅ Merged
Merged: 4/8/2024
Merged by: @LucasXu0

Base: main ← Head: 4276-translations

📝 Commits (10+)

ed1ee1f fix: set correct locale for the editor
9e66c3b fix: use command's description field
f5a1798 fix: compute correct string for locale
987a27e fix: sort commands by description
9c3bcee feat: allow for translating more shortcut commands
c04158a fix: add .tool-versions in gitignore
8b235a2 Merge branch 'main' into 4276-translations
4ec8bb5 chore: remove .tool-versions in gitignore
d7e496d Merge branch 'main' into 4276-translations
4864bec Merge branch 'main' into 4276-translations

📊 Changes

23 files changed (+80 additions, -45 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+0 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/custom_text_align_command.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/callout/callout_block_component.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/code_block/code_block_component.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/code_block/code_block_shortcut_event.dart (+10 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/context_menu/custom_context_menu.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_copy_command.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_cut_command.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_paste_command.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/database/inline_database_menu_item.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/database/referenced_database_menu_item.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/math_equation/math_equation_block_component.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/slash_menu_items.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/auto_completion_node_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/outline/outline_block_component.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcut_event.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/emoji_picker/emoji_menu_item.dart (+1 -1)

...and 3 more files

📄 Description

Feature Preview

partially fixes https://github.com/AppFlowy-IO/AppFlowy/issues/4276 by allowing for shortcuts to be translated.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4426 **Author:** [@jpenna](https://github.com/jpenna) **Created:** 1/19/2024 **Status:** ✅ Merged **Merged:** 4/8/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `4276-translations` --- ### 📝 Commits (10+) - [`ed1ee1f`](https://github.com/AppFlowy-IO/AppFlowy/commit/ed1ee1fedc80fe9c6b08caaac3c15e47097ce8dc) fix: set correct locale for the editor - [`9e66c3b`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e66c3bbb8140ae1e06de14a5d580f63ecc76836) fix: use command's `description` field - [`f5a1798`](https://github.com/AppFlowy-IO/AppFlowy/commit/f5a17989a3ba57cfb76926df50338767fa50ab53) fix: compute correct string for locale - [`987a27e`](https://github.com/AppFlowy-IO/AppFlowy/commit/987a27eedf8c61e8ac56be3de111f4f993336119) fix: sort commands by description - [`9c3bcee`](https://github.com/AppFlowy-IO/AppFlowy/commit/9c3bceee0f60d78328975fd18c987336f645093c) feat: allow for translating more shortcut commands - [`c04158a`](https://github.com/AppFlowy-IO/AppFlowy/commit/c04158abae77de776b1b4895eb974838c8c385c8) fix: add .tool-versions in gitignore - [`8b235a2`](https://github.com/AppFlowy-IO/AppFlowy/commit/8b235a23bf0db7b14a9bdb95cb6d67dc7a41350d) Merge branch 'main' into 4276-translations - [`4ec8bb5`](https://github.com/AppFlowy-IO/AppFlowy/commit/4ec8bb5589cf7f00e467a4dd97f59d091e3c2406) chore: remove .tool-versions in gitignore - [`d7e496d`](https://github.com/AppFlowy-IO/AppFlowy/commit/d7e496d2c507210bac85648f1e6ba9a50320c965) Merge branch 'main' into 4276-translations - [`4864bec`](https://github.com/AppFlowy-IO/AppFlowy/commit/4864bec76f9d4cc0caafa6a673bd9af09fbc9f1e) Merge branch 'main' into 4276-translations ### 📊 Changes **23 files changed** (+80 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+0 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/custom_text_align_command.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/callout/callout_block_component.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/code_block/code_block_component.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/code_block/code_block_shortcut_event.dart` (+10 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/context_menu/custom_context_menu.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_copy_command.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_cut_command.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_paste_command.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/database/inline_database_menu_item.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/database/referenced_database_menu_item.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/math_equation/math_equation_block_component.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/slash_menu_items.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/auto_completion_node_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/outline/outline_block_component.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcut_event.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/emoji_picker/emoji_menu_item.dart` (+1 -1) _...and 3 more files_ </details> ### 📄 Description   ### Feature Preview partially fixes https://github.com/AppFlowy-IO/AppFlowy/issues/4276 by allowing for shortcuts to be translated.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>