[PR #4471] [CLOSED] Chore/code cleanup #6262

New issue

Closed

opened 2026-03-23 22:22:26 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4471
Author: @richardshiue
Created: 1/23/2024
Status: ❌ Closed

Base: main ← Head: chore/code-cleanup

📝 Commits (10+)

ffd55c3 refactor: get row/field data from row cache and field controller in cell controller
2dc82ac refactor: reorganize cell controller tasks and builder
fce4f1e refactor: rename cell_builder.dart
c5d1d49 refactor: database editable cell builder
8573369 refactor: database card cell builder
e070b8e fix: make it work
f9cc7c1 fix: start cell listener and adjust cell style on desktop
3f17d85 fix: build card cell
d474c8a fix: remove unnecessary await in tests
0697b4b fix: cell cache validation

📊 Changes

260 files changed (+6618 additions, -7938 deletions)

View changed files

📝 frontend/appflowy_flutter/analysis_options.yaml (+3 -1)
📝 frontend/appflowy_flutter/integration_test/board/board_add_row_test.dart (+11 -13)
📝 frontend/appflowy_flutter/integration_test/board/board_group_test.dart (+5 -5)
📝 frontend/appflowy_flutter/integration_test/board/board_row_test.dart (+5 -5)
📝 frontend/appflowy_flutter/integration_test/database/database_cell_test.dart (+0 -1)
📝 frontend/appflowy_flutter/integration_test/database/database_field_settings_test.dart (+5 -5)
📝 frontend/appflowy_flutter/integration_test/database/database_field_test.dart (+5 -5)
📝 frontend/appflowy_flutter/integration_test/database/database_row_page_test.dart (+11 -22)
📝 frontend/appflowy_flutter/integration_test/database/database_share_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/document/document_alignment_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/document/document_with_database_test.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/document/document_with_image_block_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/import_files_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/util/base.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+46 -26)
📝 frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/util/mock/mock_file_picker.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/core/network_monitor.dart (+2 -5)
📝 frontend/appflowy_flutter/lib/mobile/application/mobile_router.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/board/mobile_board_content.dart (+19 -37)

...and 80 more files

📄 Description

requires https://github.com/AppFlowy-IO/AppFlowy/pull/4398

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4471 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 1/23/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `chore/code-cleanup` --- ### 📝 Commits (10+) - [`ffd55c3`](https://github.com/AppFlowy-IO/AppFlowy/commit/ffd55c3c51727ef549767467fbe48e2ae1b7aeb1) refactor: get row/field data from row cache and field controller in cell controller - [`2dc82ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/2dc82ac1c87aed73d940401eee3d29f122d12af4) refactor: reorganize cell controller tasks and builder - [`fce4f1e`](https://github.com/AppFlowy-IO/AppFlowy/commit/fce4f1e9c07848e43ccadd46111476cda11ece87) refactor: rename cell_builder.dart - [`c5d1d49`](https://github.com/AppFlowy-IO/AppFlowy/commit/c5d1d498b5e897cdb38eb4dd4686d68bdb1d8a00) refactor: database editable cell builder - [`8573369`](https://github.com/AppFlowy-IO/AppFlowy/commit/8573369061661e2263aa302d8e121d3c3ff0fba2) refactor: database card cell builder - [`e070b8e`](https://github.com/AppFlowy-IO/AppFlowy/commit/e070b8ea68eb90311d3b8a8ce9e9de441fa1a1cf) fix: make it work - [`f9cc7c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/f9cc7c121894459ce31e4470201ba33bc2f96783) fix: start cell listener and adjust cell style on desktop - [`3f17d85`](https://github.com/AppFlowy-IO/AppFlowy/commit/3f17d851ff49de0c3a9259f16860bc598a4352ee) fix: build card cell - [`d474c8a`](https://github.com/AppFlowy-IO/AppFlowy/commit/d474c8ae3da50ff63ec133c8fe33bdcae1432e37) fix: remove unnecessary await in tests - [`0697b4b`](https://github.com/AppFlowy-IO/AppFlowy/commit/0697b4b717db303fb055a1cdd0817088615a14a9) fix: cell cache validation ### 📊 Changes **260 files changed** (+6618 additions, -7938 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/analysis_options.yaml` (+3 -1) 📝 `frontend/appflowy_flutter/integration_test/board/board_add_row_test.dart` (+11 -13) 📝 `frontend/appflowy_flutter/integration_test/board/board_group_test.dart` (+5 -5) 📝 `frontend/appflowy_flutter/integration_test/board/board_row_test.dart` (+5 -5) 📝 `frontend/appflowy_flutter/integration_test/database/database_cell_test.dart` (+0 -1) 📝 `frontend/appflowy_flutter/integration_test/database/database_field_settings_test.dart` (+5 -5) 📝 `frontend/appflowy_flutter/integration_test/database/database_field_test.dart` (+5 -5) 📝 `frontend/appflowy_flutter/integration_test/database/database_row_page_test.dart` (+11 -22) 📝 `frontend/appflowy_flutter/integration_test/database/database_share_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/document/document_alignment_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_database_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/document/document_with_image_block_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/import_files_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/util/base.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+46 -26) 📝 `frontend/appflowy_flutter/integration_test/util/editor_test_operations.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/util/mock/mock_file_picker.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/core/network_monitor.dart` (+2 -5) 📝 `frontend/appflowy_flutter/lib/mobile/application/mobile_router.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/board/mobile_board_content.dart` (+19 -37) _...and 80 more files_ </details> ### 📄 Description requires https://github.com/AppFlowy-IO/AppFlowy/pull/4398 ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>