[PR #4484] [MERGED] chore: code cleanup #6266

New issue

Closed

opened 2026-03-23 22:22:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4484
Author: @richardshiue
Created: 1/24/2024
Status: ✅ Merged
Merged: 1/25/2024
Merged by: @richardshiue

Base: main ← Head: refactor/database-bloc

📝 Commits (6)

0e5f471 chore: use when instead of map in bloc event dispatch
0b4ba61 chore: dart code format
908b969 chore: don't use hashmap for cell context
aa226f2 fix: unmodifiable list
1dd7c15 fix: rebuild card content
5a3100e chore: remove unnecessary import

📊 Changes

19 files changed (+88 additions, -99 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/document/document_alignment_test.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/board/widgets/mobile_hidden_groups_column.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/select_option_cell_service.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/application/defines.dart (+0 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/field_service.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/row/row_cache.dart (+11 -13)
📝 frontend/appflowy_flutter/lib/plugins/database/application/row/row_controller.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/application/calendar_event_editor_bloc.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/row/row_bloc.dart (+15 -15)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/row/row_detail_bloc.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/mobile_row.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/row.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/card/card.dart (+0 -12)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/card/card_bloc.dart (+3 -4)
➖ frontend/appflowy_flutter/lib/plugins/database/widgets/cell/cell.dart (+0 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/cells/select_option_cell/select_option_editor_bloc.dart (+28 -29)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/align_toolbar_item.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/custom_text_align_command.dart (+1 -1)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4484 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 1/24/2024 **Status:** ✅ Merged **Merged:** 1/25/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `refactor/database-bloc` --- ### 📝 Commits (6) - [`0e5f471`](https://github.com/AppFlowy-IO/AppFlowy/commit/0e5f471be03df673f258d04e7878a37c6b592a75) chore: use when instead of map in bloc event dispatch - [`0b4ba61`](https://github.com/AppFlowy-IO/AppFlowy/commit/0b4ba618262fc91ef909766e4a195f8d5ad19be7) chore: dart code format - [`908b969`](https://github.com/AppFlowy-IO/AppFlowy/commit/908b96986b899a72a239d161bb1800c2001e1d25) chore: don't use hashmap for cell context - [`aa226f2`](https://github.com/AppFlowy-IO/AppFlowy/commit/aa226f23324d7446097acb8ad2ab4f8b00d70e9c) fix: unmodifiable list - [`1dd7c15`](https://github.com/AppFlowy-IO/AppFlowy/commit/1dd7c15735ec76f3f3913fc7f2c780537ce767c4) fix: rebuild card content - [`5a3100e`](https://github.com/AppFlowy-IO/AppFlowy/commit/5a3100e589d5166bf37a96960daa741e8865ac7f) chore: remove unnecessary import ### 📊 Changes **19 files changed** (+88 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/document/document_alignment_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/board/widgets/mobile_hidden_groups_column.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/select_option_cell_service.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/defines.dart` (+0 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/field_service.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/row/row_cache.dart` (+11 -13) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/row/row_controller.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_hidden_groups.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/application/calendar_event_editor_bloc.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/row/row_bloc.dart` (+15 -15) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/row/row_detail_bloc.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/mobile_row.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/row.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/card/card.dart` (+0 -12) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/card/card_bloc.dart` (+3 -4) ➖ `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/cell.dart` (+0 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/cells/select_option_cell/select_option_editor_bloc.dart` (+28 -29) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/align_toolbar_item.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/align_toolbar_item/custom_text_align_command.dart` (+1 -1) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>