[PR #4502] [CLOSED] chore: delete placeholder code in mobile #6277

Closed
opened 2026-03-23 22:22:30 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4502
Author: @hyj1204
Created: 1/25/2024
Status: Closed

Base: mainHead: chore/clean_code


📝 Commits (5)

  • 4dec320 refactor: refacter font size in document
  • 9e76a5c feat: resize font and icons on the sidebar and tab bar
  • e4b1d15 fix: fix format
  • 8dc8e58 chore: merge branch 'main' into feat/adjustable_font_size
  • 5765302 chore: delete placeholder code and clean code

📊 Changes

35 files changed (+347 additions, -270 deletions)

View changed files

frontend/appflowy_flutter/lib/mobile/presentation/details_placeholder_page.dart (+0 -99)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_trash_page.dart (+10 -9)
📝 frontend/appflowy_flutter/lib/mobile/presentation/presentation.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/about/about.dart (+0 -1)
frontend/appflowy_flutter/lib/mobile/presentation/setting/about/user_agreement_page.dart (+0 -22)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/notifications_setting_group.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/share_button.dart (+6 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/more/font_size_switcher.dart (+18 -14)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/more/more_button.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/share/share_button.dart (+6 -4)
📝 frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart (+0 -11)
📝 frontend/appflowy_flutter/lib/user/presentation/screens/workspace_start_screen/mobile_workspace_start_screen.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/workspace/application/home/home_setting_bloc.dart (+26 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart (+21 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart (+41 -26)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart (+28 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/folder/personal_folder.dart (+2 -1)

...and 15 more files

📄 Description

Feature Preview

  • delete placeholder code in mobile
  • clean code and update comments

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4502 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 1/25/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `chore/clean_code` --- ### 📝 Commits (5) - [`4dec320`](https://github.com/AppFlowy-IO/AppFlowy/commit/4dec3208c5b9f06ad3da2ef80914bdd42d7d90d0) refactor: refacter font size in document - [`9e76a5c`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e76a5c81332450d8f09f015ee178b8f1747296e) feat: resize font and icons on the sidebar and tab bar - [`e4b1d15`](https://github.com/AppFlowy-IO/AppFlowy/commit/e4b1d15506a37f5644ad46c49a53ee4c6f07afdb) fix: fix format - [`8dc8e58`](https://github.com/AppFlowy-IO/AppFlowy/commit/8dc8e58311ca8a5aba91e3906eb0783f5bb02a9d) chore: merge branch 'main' into feat/adjustable_font_size - [`5765302`](https://github.com/AppFlowy-IO/AppFlowy/commit/57653026d30619118e1885f314c2880fc53dde1c) chore: delete placeholder code and clean code ### 📊 Changes **35 files changed** (+347 additions, -270 deletions) <details> <summary>View changed files</summary> ➖ `frontend/appflowy_flutter/lib/mobile/presentation/details_placeholder_page.dart` (+0 -99) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_trash_page.dart` (+10 -9) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/presentation.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/about/about.dart` (+0 -1) ➖ `frontend/appflowy_flutter/lib/mobile/presentation/setting/about/user_agreement_page.dart` (+0 -22) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/notifications_setting_group.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/share_button.dart` (+6 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/more/font_size_switcher.dart` (+18 -14) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/more/more_button.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/share/share_button.dart` (+6 -4) 📝 `frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart` (+0 -11) 📝 `frontend/appflowy_flutter/lib/user/presentation/screens/workspace_start_screen/mobile_workspace_start_screen.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/workspace/application/home/home_setting_bloc.dart` (+26 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/mobile_appearance.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart` (+21 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart` (+41 -26) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart` (+28 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/folder/personal_folder.dart` (+2 -1) _...and 15 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - delete placeholder code in mobile - clean code and update comments <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:22:30 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6277
No description provided.