[PR #4514] [MERGED] fix: launch review reminder #6285

New issue

Closed

opened 2026-03-23 22:22:32 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4514
Author: @Xazin
Created: 1/26/2024
Status: ✅ Merged
Merged: 1/31/2024
Merged by: @LucasXu0

Base: main ← Head: fix/launch-review-reminder-0.4.4

📝 Commits (10+)

0a370a3 fix: dismiss menu on enter on no result
f4a91c8 fix: add drag handle to mobile reminder dialog
a01f6f3 fix: show reminder icon in date cell in grid
d0ca7b5 fix: auto select day when selecting reminder
ec7faf9 fix: increase height of notification hub
cc1bdba fix: let some reminder options require time and show time
6644d56 chore: merge branch 'upstream/main' into fix/launch-review-reminder-0.4.4
d45fde8 chore: merge branch 'upstream/main' into fix/launch-review-reminder-0.4.4
d1f5535 fix: handling of non-time reminder options
f730a4d chore: merge branch 'upstream/main' into fix/launch-review-reminder-0.4.4

📊 Changes

17 files changed (+411 additions, -123 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/database/database_reminder_test.dart (+101 -17)
📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+6 -3)
📝 frontend/appflowy_flutter/ios/Podfile.lock (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/date_picker/mobile_date_picker_screen.dart (+9 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_editor_bloc.dart (+46 -12)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_date_cell.dart (+14 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/date_editor.dart (+6 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart (+19 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_item.dart (+15 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker.dart (+14 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/mobile_appflowy_date_picker.dart (+70 -35)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_type_option_button.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/reminder_selector.dart (+92 -35)
📝 frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart (+10 -2)
📝 frontend/resources/translations/en.json (+4 -1)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4514 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 1/26/2024 **Status:** ✅ Merged **Merged:** 1/31/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/launch-review-reminder-0.4.4` --- ### 📝 Commits (10+) - [`0a370a3`](https://github.com/AppFlowy-IO/AppFlowy/commit/0a370a365c1753686a35a161b82f998065ea5361) fix: dismiss menu on enter on no result - [`f4a91c8`](https://github.com/AppFlowy-IO/AppFlowy/commit/f4a91c814a075e4e5ed61d8ef60de6d927c47b5d) fix: add drag handle to mobile reminder dialog - [`a01f6f3`](https://github.com/AppFlowy-IO/AppFlowy/commit/a01f6f34cdd1178578b5a7e26037667189101076) fix: show reminder icon in date cell in grid - [`d0ca7b5`](https://github.com/AppFlowy-IO/AppFlowy/commit/d0ca7b55d8292ba952d9aa9a17a2cb3e082da49b) fix: auto select day when selecting reminder - [`ec7faf9`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec7faf9de079d3f563b9610d620d10ea28d88928) fix: increase height of notification hub - [`cc1bdba`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc1bdba0ed084407efd26ea37e23009b83659344) fix: let some reminder options require time and show time - [`6644d56`](https://github.com/AppFlowy-IO/AppFlowy/commit/6644d56f2c470f6651104939861ed5a3ef9a277a) chore: merge branch 'upstream/main' into fix/launch-review-reminder-0.4.4 - [`d45fde8`](https://github.com/AppFlowy-IO/AppFlowy/commit/d45fde85e2556e872af3fb98adc0f0defe34c7b8) chore: merge branch 'upstream/main' into fix/launch-review-reminder-0.4.4 - [`d1f5535`](https://github.com/AppFlowy-IO/AppFlowy/commit/d1f5535e9d0e60c21901f0e0db1d4e71dc3678a8) fix: handling of non-time reminder options - [`f730a4d`](https://github.com/AppFlowy-IO/AppFlowy/commit/f730a4da1b98542bba9c20a2555e7075c1a32dd1) chore: merge branch 'upstream/main' into fix/launch-review-reminder-0.4.4 ### 📊 Changes **17 files changed** (+411 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/database/database_reminder_test.dart` (+101 -17) 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+6 -3) 📝 `frontend/appflowy_flutter/ios/Podfile.lock` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/date_picker/mobile_date_picker_screen.dart` (+9 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_editor_bloc.dart` (+46 -12) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_date_cell.dart` (+14 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/date_editor.dart` (+6 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart` (+19 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_item.dart` (+15 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker.dart` (+14 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/mobile_appflowy_date_picker.dart` (+70 -35) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_type_option_button.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/reminder_selector.dart` (+92 -35) 📝 `frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart` (+10 -2) 📝 `frontend/resources/translations/en.json` (+4 -1) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>