[PR #4523] [MERGED] fix: bottom sheet issues #6291

Closed
opened 2026-03-23 22:22:34 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4523
Author: @LucasXu0
Created: 1/28/2024
Status: Merged
Merged: 1/28/2024
Merged by: @LucasXu0

Base: mainHead: fix_bottom_sheet_issues


📝 Commits (8)

  • e12c3f8 fix: bottom sheet padding
  • 9d7cfdf fix: set divider width to 0.5px
  • f4257c1 feat: optimize number select menu
  • 0541754 chore: update edit field icons
  • c7354f7 chore: use short form in add block menu
  • 279d340 feat: optimize select and multi-select menu
  • 621f638 Merge branch 'main' into fix_bottom_sheet_issues
  • 1a51da7 feat: refactor font settings page, theme mode menu and rtl menu

📊 Changes

35 files changed (+456 additions, -255 deletions)

View changed files

frontend/appflowy_flutter/lib/mobile/presentation/base/flowy_search_text_field.dart (+40 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/option_color_list.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/default_mobile_action_pane.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+19 -6)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_option_editor.dart (+82 -16)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart (+6 -6)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_list.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/edit_database_view_screen.dart (+5 -11)
📝 frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/rtl_setting.dart (+12 -7)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/theme_setting.dart (+18 -10)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_picker_screen.dart (+17 -30)
📝 frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_option_decorate_box.dart (+5 -1)
frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_search_bar.dart (+0 -77)
frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_search_text_field.dart (+40 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_option_tile.dart (+30 -15)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/number_format_bloc.dart (+78 -14)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/extension.dart (+13 -9)

...and 15 more files

📄 Description

Feature Preview

Screenshot 2024-01-28 at 11 27 22 Screenshot 2024-01-28 at 11 12 15 Screenshot 2024-01-28 at 10 33 47 Screenshot 2024-01-28 at 10 30 47 Screenshot 2024-01-28 at 10 26 51 Screenshot 2024-01-28 at 10 26 07 Screenshot 2024-01-28 at 10 10 24 Screenshot 2024-01-28 at 10 08 53 Screenshot 2024-01-28 at 10 03 50 Screenshot 2024-01-28 at 11 36 38 Screenshot 2024-01-28 at 21 19 30

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4523 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 1/28/2024 **Status:** ✅ Merged **Merged:** 1/28/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_bottom_sheet_issues` --- ### 📝 Commits (8) - [`e12c3f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/e12c3f8d7051c6d871529b02eca1f3fe5fd89ea2) fix: bottom sheet padding - [`9d7cfdf`](https://github.com/AppFlowy-IO/AppFlowy/commit/9d7cfdf3aed2224600600acabe92da393399c053) fix: set divider width to 0.5px - [`f4257c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/f4257c1dde44aa633170e0c5a69ed7cc41d2df2d) feat: optimize number select menu - [`0541754`](https://github.com/AppFlowy-IO/AppFlowy/commit/054175498a5f800ad84d5a90f59518f2a097df1e) chore: update edit field icons - [`c7354f7`](https://github.com/AppFlowy-IO/AppFlowy/commit/c7354f798936fbcfa66cef6a33d3eac58c7157e4) chore: use short form in add block menu - [`279d340`](https://github.com/AppFlowy-IO/AppFlowy/commit/279d340202a937df884736f9ff0eeb631ac62247) feat: optimize select and multi-select menu - [`621f638`](https://github.com/AppFlowy-IO/AppFlowy/commit/621f638b687c2955c72bb772623d6109c5ed8480) Merge branch 'main' into fix_bottom_sheet_issues - [`1a51da7`](https://github.com/AppFlowy-IO/AppFlowy/commit/1a51da72b53f920e11b8e03f3bce5c34e37b2cc4) feat: refactor font settings page, theme mode menu and rtl menu ### 📊 Changes **35 files changed** (+456 additions, -255 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/lib/mobile/presentation/base/flowy_search_text_field.dart` (+40 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/option_color_list.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/default_mobile_action_pane.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+19 -6) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_option_editor.dart` (+82 -16) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart` (+6 -6) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_list.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/edit_database_view_screen.dart` (+5 -11) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/rtl_setting.dart` (+12 -7) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/theme_setting.dart` (+18 -10) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/font/font_picker_screen.dart` (+17 -30) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_option_decorate_box.dart` (+5 -1) ➖ `frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_search_bar.dart` (+0 -77) ➕ `frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_mobile_search_text_field.dart` (+40 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/widgets/flowy_option_tile.dart` (+30 -15) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/type_option/number_format_bloc.dart` (+78 -14) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/extension.dart` (+13 -9) _...and 15 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <img width="402" alt="Screenshot 2024-01-28 at 11 27 22" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/6e923bad-fa6e-46b4-b427-6cb1cf6d1710"> <img width="424" alt="Screenshot 2024-01-28 at 11 12 15" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/45307b6a-820e-418d-957d-195ebee09c44"> <img width="830" alt="Screenshot 2024-01-28 at 10 33 47" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/8186f559-6a80-481a-b792-90af2bae5a8b"> <img width="799" alt="Screenshot 2024-01-28 at 10 30 47" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/bed55139-9003-42c4-a33a-4db7e709a911"> <img width="821" alt="Screenshot 2024-01-28 at 10 26 51" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/25c04452-9dcf-467e-b87d-e4e401828a0b"> <img width="817" alt="Screenshot 2024-01-28 at 10 26 07" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/47ae68c5-7462-44f1-bbcc-a9de833c9012"> <img width="810" alt="Screenshot 2024-01-28 at 10 10 24" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/43caad62-8c01-4651-8192-2614c6a95257"> <img width="809" alt="Screenshot 2024-01-28 at 10 08 53" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/f6759aa8-bf59-46a7-9326-612956be22a0"> <img width="803" alt="Screenshot 2024-01-28 at 10 03 50" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/1dcd526d-5895-4d18-9018-c9f6adfd499a"> <img width="391" alt="Screenshot 2024-01-28 at 11 36 38" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/89a8b0a4-7e1f-4567-9151-b41c3dfebe05"> <img width="400" alt="Screenshot 2024-01-28 at 21 19 30" src="https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/3356570a-bc29-40ec-bb8d-c05a8000f94b"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:22:34 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6291
No description provided.