[PR #4534] [MERGED] fix: mobile field editing related bugs #6293

Closed
opened 2026-03-23 22:22:34 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4534
Author: @richardshiue
Created: 1/29/2024
Status: Merged
Merged: 1/29/2024
Merged by: @richardshiue

Base: mainHead: fix/mobile-field-editor


📝 Commits (4)

  • 6d08f12 fix: mobile field editing related bugs
  • 2a929f2 chore: merge remote-tracking branch 'upstream/main' into fix/mobile-field-editor
  • 7c89bb7 chore: review
  • 617121c chore: restore podfile.lock

📊 Changes

7 files changed (+136 additions, -108 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_create_field_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_edit_field_screen.dart (+61 -68)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart (+11 -7)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_grid.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_option_editor.dart (+23 -18)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart (+37 -9)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_field_list.dart (+1 -3)

📄 Description

  • field type option data not getting updated during field editing
  • back navigation gesture not saving field updates during field editing
  • changing field type when creating a new field always changes the name of the field.

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4534 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 1/29/2024 **Status:** ✅ Merged **Merged:** 1/29/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/mobile-field-editor` --- ### 📝 Commits (4) - [`6d08f12`](https://github.com/AppFlowy-IO/AppFlowy/commit/6d08f12024ee36ba94eb72f02106a6001111fa19) fix: mobile field editing related bugs - [`2a929f2`](https://github.com/AppFlowy-IO/AppFlowy/commit/2a929f26247173dc44d5b30f923039fc1cea651d) chore: merge remote-tracking branch 'upstream/main' into fix/mobile-field-editor - [`7c89bb7`](https://github.com/AppFlowy-IO/AppFlowy/commit/7c89bb7cf949dfbb2288c588121dec44848b84e5) chore: review - [`617121c`](https://github.com/AppFlowy-IO/AppFlowy/commit/617121c3db9b1bb8cc9be65de533df8ef2ab4053) chore: restore podfile.lock ### 📊 Changes **7 files changed** (+136 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_create_field_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_edit_field_screen.dart` (+61 -68) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart` (+11 -7) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_grid.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_option_editor.dart` (+23 -18) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_quick_field_editor.dart` (+37 -9) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_field_list.dart` (+1 -3) </details> ### 📄 Description - field type option data not getting updated during field editing - back navigation gesture not saving field updates during field editing - changing field type when creating a new field always changes the name of the field. ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:22:34 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6293
No description provided.