[PR #4561] [MERGED] fix: mobile UI issues #6316

Closed
opened 2026-03-23 22:22:41 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4561
Author: @richardshiue
Created: 1/31/2024
Status: Merged
Merged: 1/31/2024
Merged by: @LucasXu0

Base: mainHead: fix/mobile-ui-issues


📝 Commits (10+)

  • cf7b9f6 fix: don't re-request focus after editing a cell
  • 083b0d5 fix: card detail more actions
  • 9de4308 fix: select option indicators
  • 80bf1a6 fix: add field bottom sheet revamp
  • 5671c50 fix: edit field type bottom sheet
  • 78fd522 chore: bump spacing between header and first row of field types
  • f22f97c fix: grid spacing
  • e6c86f9 refactor: use svg and background colors
  • ba34fb2 refactor: use shared component
  • a6ef1ad chore: merge remote-tracking branch 'upstream/main' into fix/mobile-ui-issues

📊 Changes

50 files changed (+252 additions, -443 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/util/database_test_op.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart (+17 -17)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/mobile_row_property_list.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/option_text_field.dart (+14 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart (+59 -27)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_picker_list.dart (+2 -2)
frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_grid.dart (+0 -170)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_option_editor.dart (+33 -15)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_field_list.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/choicechip.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/create_filter_list.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/desktop_field_cell.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/field_editor.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/field_type_extension.dart (+0 -53)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/field_type_list.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/mobile_field_button.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/sort/create_sort_list.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_url_cell.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_select_option_editor.dart (+60 -7)

...and 30 more files

📄 Description

  1. Fix bug: in the mobile row detail page, when editing the title of the row, clicking on a cell editor and then closing it brings keyboard focus back to the title.

  2. Add drag handler to the mobile row detail "more action" bottom menu
    image

  3. Select option cell editor now has theme-respecting indicator icons, and differ between single/multi-select field types

image image

  1. Create field and edit field type bottom sheets have been revamped to include a distinct header, divider and close button. Also make it take up half of the screen by default, and upwards expansion to 85% that fits all of the cells

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/59ebf835-9aeb-4511-b302-d33865c57c97

  1. last modified and created at field types get their own icons. see above

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4561 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 1/31/2024 **Status:** ✅ Merged **Merged:** 1/31/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/mobile-ui-issues` --- ### 📝 Commits (10+) - [`cf7b9f6`](https://github.com/AppFlowy-IO/AppFlowy/commit/cf7b9f6854d36e3678868be5c4eedbacbe332f6b) fix: don't re-request focus after editing a cell - [`083b0d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/083b0d5baf0c7438b7201abb7001970d2a49936e) fix: card detail more actions - [`9de4308`](https://github.com/AppFlowy-IO/AppFlowy/commit/9de43080c5498902693f214f11b34648fa977812) fix: select option indicators - [`80bf1a6`](https://github.com/AppFlowy-IO/AppFlowy/commit/80bf1a6b267c91a97f15db68f30a7dfab50a6fa6) fix: add field bottom sheet revamp - [`5671c50`](https://github.com/AppFlowy-IO/AppFlowy/commit/5671c5017bab682f7a9f74a7c87d32dcdbf4092e) fix: edit field type bottom sheet - [`78fd522`](https://github.com/AppFlowy-IO/AppFlowy/commit/78fd5227076931fa527b0ce5ddbfd6dffca27a11) chore: bump spacing between header and first row of field types - [`f22f97c`](https://github.com/AppFlowy-IO/AppFlowy/commit/f22f97ccc61b6b45e5fe5a4fccc00448fd1ef974) fix: grid spacing - [`e6c86f9`](https://github.com/AppFlowy-IO/AppFlowy/commit/e6c86f9978f2af0600c807737d87970f8bb25fa9) refactor: use svg and background colors - [`ba34fb2`](https://github.com/AppFlowy-IO/AppFlowy/commit/ba34fb275948e2285de50ba3295bbf3d1aea4142) refactor: use shared component - [`a6ef1ad`](https://github.com/AppFlowy-IO/AppFlowy/commit/a6ef1add358ccd477fce7a762008655e35fd8962) chore: merge remote-tracking branch 'upstream/main' into fix/mobile-ui-issues ### 📊 Changes **50 files changed** (+252 additions, -443 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/util/database_test_op.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart` (+17 -17) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/mobile_row_property_list.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/option_text_field.dart` (+14 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart` (+59 -27) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_picker_list.dart` (+2 -2) ➖ `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_grid.dart` (+0 -170) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_type_option_editor.dart` (+33 -15) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_field_list.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/choicechip.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/create_filter_list.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/desktop_field_cell.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/field_editor.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/field_type_extension.dart` (+0 -53) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/field_type_list.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/header/mobile_field_button.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/sort/create_sort_list.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_url_cell.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_select_option_editor.dart` (+60 -7) _...and 30 more files_ </details> ### 📄 Description 1. Fix bug: in the mobile row detail page, when editing the title of the row, clicking on a cell editor and then closing it brings keyboard focus back to the title. 2. Add drag handler to the mobile row detail "more action" bottom menu <img width="436" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/c102f129-903a-42e5-bba6-2593dda065bd"> 3. Select option cell editor now has theme-respecting indicator icons, and differ between single/multi-select field types <img width="405" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/7410d87e-0923-4eb6-8842-933b3dcffdaa"> <img width="407" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/959be651-13f9-4cf7-afe7-d991e2c05d94"> 4. Create field and edit field type bottom sheets have been revamped to include a distinct header, divider and close button. Also make it take up half of the screen by default, and upwards expansion to 85% that fits all of the cells https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/59ebf835-9aeb-4511-b302-d33865c57c97 5. last modified and created at field types get their own icons. see above ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:22:41 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6316
No description provided.