[PR #4602] [MERGED] chore: revamp mobile url editor #6342

Closed
opened 2026-03-23 22:22:47 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4602
Author: @richardshiue
Created: 2/4/2024
Status: Merged
Merged: 3/14/2024
Merged by: @appflowy

Base: mainHead: chore/mobile-url-revamp


📝 Commits (10+)

  • 1161298 chore: revamp mobile url editor
  • 0388cc5 chore: add i18n
  • 1fd7aff chore: merge remote-tracking branch 'upstream/main' into chore/mobile-url-revamp
  • 8ecced1 chore: merge remote-tracking branch 'upstream/main' into chore/mobile-url-revamp
  • 595fa2e chore: use shared url launcher
  • b085fef chore: translation bump
  • 7e3e195 chore: add a toast notification after URL is copied to clipboard
  • 63f4f89 chore: listen to onchanged
  • cd53118 chore: improve text field editing experience
  • c382290 chore: disable quick action buttons if url cell data is empty

📊 Changes

20 files changed (+192 additions, -140 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_rename_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_url_cell.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/url.dart (+78 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_url_cell.dart (+20 -52)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_url_cell.dart (+12 -34)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart (+3 -4)
📝 frontend/resources/translations/ar-SA.json (+5 -3)
📝 frontend/resources/translations/ca-ES.json (+5 -3)
📝 frontend/resources/translations/de-DE.json (+5 -3)
📝 frontend/resources/translations/en.json (+7 -3)
📝 frontend/resources/translations/es-VE.json (+5 -3)
📝 frontend/resources/translations/fr-CA.json (+6 -4)
📝 frontend/resources/translations/fr-FR.json (+5 -3)
📝 frontend/resources/translations/it-IT.json (+5 -3)
📝 frontend/resources/translations/pt-BR.json (+5 -3)
📝 frontend/resources/translations/ru-RU.json (+5 -3)
📝 frontend/resources/translations/th-TH.json (+9 -7)
📝 frontend/resources/translations/vi-VN.json (+4 -2)
📝 frontend/resources/translations/zh-CN.json (+5 -3)
📝 frontend/resources/translations/zh-TW.json (+5 -3)

📄 Description

Before:

Screenshot 2024-03-20 at 5 46 57 PM

After:

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/eed5d40d-f379-46a4-993d-7c2c0f5cb586

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4602 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/4/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `chore/mobile-url-revamp` --- ### 📝 Commits (10+) - [`1161298`](https://github.com/AppFlowy-IO/AppFlowy/commit/11612988a033e5e6d3edeb2c9cf8cd599c0e2db0) chore: revamp mobile url editor - [`0388cc5`](https://github.com/AppFlowy-IO/AppFlowy/commit/0388cc53c03974c461edbef48a7a185fa8557653) chore: add i18n - [`1fd7aff`](https://github.com/AppFlowy-IO/AppFlowy/commit/1fd7aff86ed8cd68585552315ebf75f6ed00f47b) chore: merge remote-tracking branch 'upstream/main' into chore/mobile-url-revamp - [`8ecced1`](https://github.com/AppFlowy-IO/AppFlowy/commit/8ecced1e559b81e905704dd9a5e7b5a4388eaaed) chore: merge remote-tracking branch 'upstream/main' into chore/mobile-url-revamp - [`595fa2e`](https://github.com/AppFlowy-IO/AppFlowy/commit/595fa2e8e9cf421f8de4b2b44180074727965073) chore: use shared url launcher - [`b085fef`](https://github.com/AppFlowy-IO/AppFlowy/commit/b085fefcd785a2abaf24e98d8344b715d60779eb) chore: translation bump - [`7e3e195`](https://github.com/AppFlowy-IO/AppFlowy/commit/7e3e1953f5135af13c06b50346a65b626c19f2aa) chore: add a toast notification after URL is copied to clipboard - [`63f4f89`](https://github.com/AppFlowy-IO/AppFlowy/commit/63f4f89d3fade34f8c2defb3642b58666901ec98) chore: listen to onchanged - [`cd53118`](https://github.com/AppFlowy-IO/AppFlowy/commit/cd531187509cf14a2987662f24aa2dac8aaebab6) chore: improve text field editing experience - [`c382290`](https://github.com/AppFlowy-IO/AppFlowy/commit/c38229058221f3a3a5154ce6da9f5e5fa2f8896e) chore: disable quick action buttons if url cell data is empty ### 📊 Changes **20 files changed** (+192 additions, -140 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_rename_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_url_cell.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/url.dart` (+78 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_url_cell.dart` (+20 -52) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_url_cell.dart` (+12 -34) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_field.dart` (+3 -4) 📝 `frontend/resources/translations/ar-SA.json` (+5 -3) 📝 `frontend/resources/translations/ca-ES.json` (+5 -3) 📝 `frontend/resources/translations/de-DE.json` (+5 -3) 📝 `frontend/resources/translations/en.json` (+7 -3) 📝 `frontend/resources/translations/es-VE.json` (+5 -3) 📝 `frontend/resources/translations/fr-CA.json` (+6 -4) 📝 `frontend/resources/translations/fr-FR.json` (+5 -3) 📝 `frontend/resources/translations/it-IT.json` (+5 -3) 📝 `frontend/resources/translations/pt-BR.json` (+5 -3) 📝 `frontend/resources/translations/ru-RU.json` (+5 -3) 📝 `frontend/resources/translations/th-TH.json` (+9 -7) 📝 `frontend/resources/translations/vi-VN.json` (+4 -2) 📝 `frontend/resources/translations/zh-CN.json` (+5 -3) 📝 `frontend/resources/translations/zh-TW.json` (+5 -3) </details> ### 📄 Description Before: ![Screenshot 2024-03-20 at 5 46 57 PM](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/0e3e2ea0-853c-4ba1-9801-ff48dd4ad42c) After: https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/eed5d40d-f379-46a4-993d-7c2c0f5cb586 ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:22:47 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6342
No description provided.