[PR #4655] [MERGED] refactor: use BoxAny for dynamically-typed cell changesets #6369

New issue

Closed

opened 2026-03-23 22:22:55 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4655
Author: @richardshiue
Created: 2/14/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @appflowy

Base: main ← Head: refactor/box-any-cell-changeset

📝 Commits (2)

7f92560 refactor: use BoxAny for dynamically-typed cell changesets
65701aa fix: rust-lib tests and clippy

📊 Changes

22 files changed (+161 additions, -268 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/date_cell_service.dart (+2 -2)
📝 frontend/appflowy_tauri/src/appflowy_app/application/database/cell/cell_service.ts (+2 -2)
📝 frontend/rust-lib/event-integration/src/database_event.rs (+1 -1)
📝 frontend/rust-lib/event-integration/tests/database/local_test/test.rs (+5 -5)
📝 frontend/rust-lib/flowy-database2/src/entities/type_option_entities/date_entities.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+13 -8)
📝 frontend/rust-lib/flowy-database2/src/event_map.rs (+2 -2)
📝 frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs (+40 -82)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+11 -13)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist_entities.rs (+1 -18)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs (+2 -19)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/mod.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_type_option.rs (+2 -20)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option.rs (+4 -5)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option_cell.rs (+8 -8)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/date_controller.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/select_option_controller/util.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/tests/database/cell_test/script.rs (+18 -14)
📝 frontend/rust-lib/flowy-database2/tests/database/cell_test/test.rs (+29 -31)
📝 frontend/rust-lib/flowy-database2/tests/database/database_editor.rs (+14 -16)

...and 2 more files

📄 Description

also rename DateChangesetPB to DateCellChangesetPB

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4655 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/14/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `refactor/box-any-cell-changeset` --- ### 📝 Commits (2) - [`7f92560`](https://github.com/AppFlowy-IO/AppFlowy/commit/7f92560a05f5b1e72b7b76122d5161e2ee708e6f) refactor: use BoxAny for dynamically-typed cell changesets - [`65701aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/65701aa07ef28bc7138893bdf8ddacc57bb8bc94) fix: rust-lib tests and clippy ### 📊 Changes **22 files changed** (+161 additions, -268 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/date_cell_service.dart` (+2 -2) 📝 `frontend/appflowy_tauri/src/appflowy_app/application/database/cell/cell_service.ts` (+2 -2) 📝 `frontend/rust-lib/event-integration/src/database_event.rs` (+1 -1) 📝 `frontend/rust-lib/event-integration/tests/database/local_test/test.rs` (+5 -5) 📝 `frontend/rust-lib/flowy-database2/src/entities/type_option_entities/date_entities.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+13 -8) 📝 `frontend/rust-lib/flowy-database2/src/event_map.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs` (+40 -82) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+11 -13) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist_entities.rs` (+1 -18) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs` (+2 -19) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/mod.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_type_option.rs` (+2 -20) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option.rs` (+4 -5) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option_cell.rs` (+8 -8) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/date_controller.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/select_option_controller/util.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/tests/database/cell_test/script.rs` (+18 -14) 📝 `frontend/rust-lib/flowy-database2/tests/database/cell_test/test.rs` (+29 -31) 📝 `frontend/rust-lib/flowy-database2/tests/database/database_editor.rs` (+14 -16) _...and 2 more files_ </details> ### 📄 Description - also rename `DateChangesetPB` to `DateCellChangesetPB` ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>