[PR #4659] [MERGED] feat: checklist sort #6371

Closed
opened 2026-03-23 22:22:56 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4659
Author: @richardshiue
Created: 2/16/2024
Status: Merged
Merged: 2/22/2024
Merged by: @appflowy

Base: mainHead: feat/checklist-sort


📝 Commits (7)

  • 7f92560 refactor: use BoxAny for dynamically-typed cell changesets
  • 65701aa fix: rust-lib tests and clippy
  • 0bd33b4 feat: enable sorting by checklist type option
  • fc31b61 test: checklist sort rust-lib tests
  • 61b0ab2 chore: update related tests
  • ccdbccf fix: clippy
  • 9e6402e Merge branch 'main' into feat/checklist-sort

📊 Changes

13 files changed (+150 additions, -50 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/field/field_info.dart (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/event_handler.rs (+5 -1)
📝 frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs (+5 -6)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist.rs (+19 -13)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist_entities.rs (+12 -7)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option.rs (+9 -12)
📝 frontend/rust-lib/flowy-database2/tests/database/cell_test/test.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/tests/database/database_editor.rs (+2 -2)
📝 frontend/rust-lib/flowy-database2/tests/database/filter_test/checklist_filter_test.rs (+2 -2)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs (+0 -1)
📝 frontend/rust-lib/flowy-database2/tests/database/mock_data/grid_mock_data.rs (+16 -1)
📝 frontend/rust-lib/flowy-database2/tests/database/share_test/export_test.rs (+4 -4)
📝 frontend/rust-lib/flowy-database2/tests/database/sort_test/single_sort_test.rs (+74 -0)

📄 Description

requires #4655

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4659 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/16/2024 **Status:** ✅ Merged **Merged:** 2/22/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat/checklist-sort` --- ### 📝 Commits (7) - [`7f92560`](https://github.com/AppFlowy-IO/AppFlowy/commit/7f92560a05f5b1e72b7b76122d5161e2ee708e6f) refactor: use BoxAny for dynamically-typed cell changesets - [`65701aa`](https://github.com/AppFlowy-IO/AppFlowy/commit/65701aa07ef28bc7138893bdf8ddacc57bb8bc94) fix: rust-lib tests and clippy - [`0bd33b4`](https://github.com/AppFlowy-IO/AppFlowy/commit/0bd33b4fac292f50ff66efd552c9dfbd7fd2c174) feat: enable sorting by checklist type option - [`fc31b61`](https://github.com/AppFlowy-IO/AppFlowy/commit/fc31b61fc88ae2592e4dbcb52d3d939a55180042) test: checklist sort rust-lib tests - [`61b0ab2`](https://github.com/AppFlowy-IO/AppFlowy/commit/61b0ab2b9c63ddb09718d8a0c25a396329fcf213) chore: update related tests - [`ccdbccf`](https://github.com/AppFlowy-IO/AppFlowy/commit/ccdbccf28440646725cd3f8e331f31b2e90bb8e0) fix: clippy - [`9e6402e`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e6402e54c2c47f6b9b2260228f9a5eb5cfa7fb0) Merge branch 'main' into feat/checklist-sort ### 📊 Changes **13 files changed** (+150 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/field_info.dart` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/event_handler.rs` (+5 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs` (+5 -6) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist.rs` (+19 -13) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/checklist_type_option/checklist_entities.rs` (+12 -7) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/type_option.rs` (+9 -12) 📝 `frontend/rust-lib/flowy-database2/tests/database/cell_test/test.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/tests/database/database_editor.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/tests/database/filter_test/checklist_filter_test.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs` (+0 -1) 📝 `frontend/rust-lib/flowy-database2/tests/database/mock_data/grid_mock_data.rs` (+16 -1) 📝 `frontend/rust-lib/flowy-database2/tests/database/share_test/export_test.rs` (+4 -4) 📝 `frontend/rust-lib/flowy-database2/tests/database/sort_test/single_sort_test.rs` (+74 -0) </details> ### 📄 Description requires #4655 ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:22:56 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6371
No description provided.