[PR #4661] [MERGED] fix: newly-created rows aren't being automatically sorted #6373

New issue

Closed

opened 2026-03-23 22:22:56 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:22:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4661
Author: @richardshiue
Created: 2/16/2024
Status: ✅ Merged
Merged: 2/20/2024
Merged by: @richardshiue

Base: main ← Head: fix/new-row-no-sort

📝 Commits (4)

e478095 fix: newly-created rows aren't being automatically sorted
f89dfbc chore: new database view collab notification and add test
3b8701e fix: WIP implement this fix...
15778d5 fix: implement fix properly

📊 Changes

6 files changed (+108 additions, -6 deletions)

View changed files

📝 frontend/rust-lib/flowy-database2/src/services/database_view/notifier.rs (+3 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+12 -3)
📝 frontend/rust-lib/flowy-database2/src/services/sort/controller.rs (+35 -1)
📝 frontend/rust-lib/flowy-database2/src/services/sort/entities.rs (+7 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/sort_test/script.rs (+24 -0)
📝 frontend/rust-lib/flowy-database2/tests/database/sort_test/single_sort_test.rs (+27 -1)

📄 Description

resolves #4600

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4661 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/16/2024 **Status:** ✅ Merged **Merged:** 2/20/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/new-row-no-sort` --- ### 📝 Commits (4) - [`e478095`](https://github.com/AppFlowy-IO/AppFlowy/commit/e47809586297990eec935e8816a3302372bad5a3) fix: newly-created rows aren't being automatically sorted - [`f89dfbc`](https://github.com/AppFlowy-IO/AppFlowy/commit/f89dfbc24a6ac47e89ae35a6c0b2b74295f94af4) chore: new database view collab notification and add test - [`3b8701e`](https://github.com/AppFlowy-IO/AppFlowy/commit/3b8701eeeb6c47d231b8ebccecd0a1405829f57f) fix: WIP implement this fix... - [`15778d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/15778d521f7b287d10433cf6bf05f10be741238d) fix: implement fix properly ### 📊 Changes **6 files changed** (+108 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/notifier.rs` (+3 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+12 -3) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/controller.rs` (+35 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/entities.rs` (+7 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/sort_test/script.rs` (+24 -0) 📝 `frontend/rust-lib/flowy-database2/tests/database/sort_test/single_sort_test.rs` (+27 -1) </details> ### 📄 Description resolves #4600 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>