[PR #4679] [MERGED] feat: optimize image upload process and display an error message if upload fails #6383

Closed
opened 2026-03-23 22:22:59 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4679
Author: @LucasXu0
Created: 2/19/2024
Status: Merged
Merged: 2/19/2024
Merged by: @LucasXu0

Base: mainHead: optimize_image_upload


📝 Commits (4)

  • 8ce24fd chore: optimize image upload
  • 821426a Merge branch 'main' into optimize_image_upload
  • 94d29f1 feat: show upload image status
  • f243e71 chore: upload the ai image to cloud server

📊 Changes

7 files changed (+60 additions, -16 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/application/doc_service.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_placeholder.dart (+28 -11)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_util.dart (+6 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/resizeable_image.dart (+1 -0)
frontend/appflowy_flutter/lib/shared/cloud_image_checker.dart (+20 -0)
📝 frontend/resources/translations/en.json (+2 -1)

📄 Description

Feature Preview

  • show the error message if the image upload fails.
  • display a progress indicator during image upload.

https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/0593eb9c-b0ca-46ce-a9de-0ca4d6280e14


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4679 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 2/19/2024 **Status:** ✅ Merged **Merged:** 2/19/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `optimize_image_upload` --- ### 📝 Commits (4) - [`8ce24fd`](https://github.com/AppFlowy-IO/AppFlowy/commit/8ce24fd6e72580edfb0187a8300378b951a71e9b) chore: optimize image upload - [`821426a`](https://github.com/AppFlowy-IO/AppFlowy/commit/821426af4493bbb87f22f8fd568ea9fbc48d4563) Merge branch 'main' into optimize_image_upload - [`94d29f1`](https://github.com/AppFlowy-IO/AppFlowy/commit/94d29f1f328b147e0365896e8a27ece1a1d65d24) feat: show upload image status - [`f243e71`](https://github.com/AppFlowy-IO/AppFlowy/commit/f243e7115d087915963670fa83c5064a730c7625) chore: upload the ai image to cloud server ### 📊 Changes **7 files changed** (+60 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/application/doc_service.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_header_node_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_placeholder.dart` (+28 -11) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/image_util.dart` (+6 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/resizeable_image.dart` (+1 -0) ➕ `frontend/appflowy_flutter/lib/shared/cloud_image_checker.dart` (+20 -0) 📝 `frontend/resources/translations/en.json` (+2 -1) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - show the error message if the image upload fails. - display a progress indicator during image upload. https://github.com/AppFlowy-IO/AppFlowy/assets/11863087/0593eb9c-b0ca-46ce-a9de-0ca4d6280e14 <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:22:59 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#6383
No description provided.