[PR #4689] [MERGED] chore: adjust show mobile bottom sheet #6389

New issue

Closed

opened 2026-03-23 22:23:00 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:23:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/4689
Author: @richardshiue
Created: 2/21/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @richardshiue

Base: main ← Head: chore/transition-bottom-sheet-precursor

📝 Commits (1)

f57fe0a chore: adjust show mobile bottom sheet

📊 Changes

19 files changed (+19 additions, -47 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+9 -23)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/date_picker/mobile_date_picker_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart (+0 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_picker_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_full_field_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_list.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/edit_database_view_screen.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/plugins/base/drag_handler.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_checklist_cell.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_date_cell.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_select_option_cell.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_checklist_cell.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_date_cell.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_select_cell_option.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_checklist_cell_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_select_option_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/setting/mobile_database_controls.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/mobile_appflowy_date_picker.dart (+1 -2)

📄 Description

This is a precursor to the mobile transition PR for easier review.

adjust top corner radius from 12px to 16px
remove unnecessary provided padding = EdgeInsets.zero in some showMobileBottomSheet calls
remove resizeToAvoidBottomInsets since default padding is already added later down, if I understand it correctly
rename DragHandler to DragHandle

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/4689 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 2/21/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `chore/transition-bottom-sheet-precursor` --- ### 📝 Commits (1) - [`f57fe0a`](https://github.com/AppFlowy-IO/AppFlowy/commit/f57fe0ac39be08d850585b0bf8c3c78463b21daa) chore: adjust show mobile bottom sheet ### 📊 Changes **19 files changed** (+19 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+9 -23) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/date_picker/mobile_date_picker_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_bottom_sheets.dart` (+0 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_field_picker_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/field/mobile_full_field_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_list.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/edit_database_view_screen.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/plugins/base/drag_handler.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_checklist_cell.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_date_cell.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_select_option_cell.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_checklist_cell.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_date_cell.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_select_cell_option.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_checklist_cell_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_select_option_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/setting/mobile_database_controls.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/mobile_appflowy_date_picker.dart` (+1 -2) </details> ### 📄 Description This is a precursor to the mobile transition PR for easier review. - adjust top corner radius from 12px to 16px - remove unnecessary provided `padding = EdgeInsets.zero` in some `showMobileBottomSheet` calls - remove `resizeToAvoidBottomInsets` since default padding is already added later down, if I understand it correctly - rename `DragHandler` to `DragHandle` ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>